Closed
Bug 457762
Opened 16 years ago
Closed 16 years ago
Combo boxes for selecting builds show all builds, rather than just the active ones
Categories
(Testopia :: Test Runs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmalcolm, Assigned: gregaryh)
Details
Attachments
(1 file, 1 obsolete file)
1006 bytes,
patch
|
gregaryh
:
review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008071018 Red Hat/3.0.1-1.el5 Firefox/3.0.1
Build Identifier: TR2.1
We have a large number of old builds, needed for storing "historical" results which we can compare against new test results. Most of these are inactive.
However the build selection combo boxes in the UI always show all of them. I believe we (almost?) always want the UI to filter these combo boxes just to show active builds.
Reproducible: Always
Steps to Reproduce:
1. click on New Run; get taken to tr_new_run.cgi
2. select a plan; get taken to tr_new_run.cgi?plan_id=61 (or whatever)
3. go to bottom of page, click on "Build" combo box
Actual Results:
all builds, ever, for that product appear
Expected Results:
only active builds for the product should appear
Reporter | ||
Comment 1•16 years ago
|
||
Have only been testing so far with the New Run UI as described in the bug. grepping in testopia/js shows various other uses. I've only done a quick visual scan of those and may have missed a case where you'd want to show all.
Attachment #341000 -
Flags: review?(ghendricks)
Comment 2•16 years ago
|
||
I tried implementing this patch in Testopia 2.1 and repeating the steps to reproduce. I didn't notice any difference in behaviour - all the builds still displayed in the drop-down menu.
It's also worth noting the same problem is happening with environments. I'm seeing a long list of inactive environments in the drop-down menu when creating a run.
Reporter | ||
Updated•16 years ago
|
Attachment #341000 -
Flags: review?(ghendricks)
Reporter | ||
Comment 3•16 years ago
|
||
Comment on attachment 341000 [details] [diff] [review]
Patch makes all build combos filtered to only show active builds
I'm not happy with this patch; looks like I'm missing at least a "var" for the params.
Sorry for the noise; will try to fix things up
Reporter | ||
Comment 4•16 years ago
|
||
Attachment #341000 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Attachment #341931 -
Flags: review?(ghendricks)
Assignee | ||
Comment 5•16 years ago
|
||
Comment on attachment 341931 [details] [diff] [review]
Updated patch, fix issue with missing "var"
It is conceivable that at some point we would want to have a list of all builds, not just the active ones. I think this is a good start, but it needs to be optional.
Also, the need for a separate myparams object is unnecessary since the cfg.params already serves this purpose. so you could simply say
cfg.params.activeonly = 1
Attachment #341931 -
Flags: review?(ghendricks) → review-
Assignee | ||
Comment 6•16 years ago
|
||
Hmmm, on further investigation, the only place where I see this exibited is on the clone form. All you have to do is add activeonly: 1 to the params of the BuildCombo instantiation:
var bbox = new BuildCombo({
fieldLabel: 'Select a Build',
id: 'plan_clone_build_chooser',
mode: 'local',
hiddenName: 'new_run_build',
params: {product_id: plan.product_id, activeonly: 1}
});
Anyway, I have added it to the missing locations in the clone forms.
Checking in testopia/js/run.js;
/cvsroot/mozilla/webtools/testopia/testopia/js/run.js,v <-- run.js
new revision: 1.38; previous revision: 1.37
done
Checking in testopia/js/plan.js;
/cvsroot/mozilla/webtools/testopia/testopia/js/plan.js,v <-- plan.js
new revision: 1.25; previous revision: 1.24
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•