457820 - Shredder reinstates deleted recipients

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Eliot Lear]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080928030741 Shredder/3.0b1pre

Recipients get reinstated after the user has deleted them when one tabs to the subject line.

Reproducible: Always

Steps to Reproduce:
1. Start by creating a new message.
2. Add two recipients
3. Create a new recipient line, but don't fill it in.
4. Remove second recipient (cut).
5. Tab to the subject line.

Actual Results:  
Deleted recipient gets reinstated!!

Expected Results:  
Deleted recipient stays deleted

If you remove the line that the 2nd recipient was on, the problem does not occur. Behavior has been around a while.

Comment 1

[Wayne Mery (:wsmwk)]

Mark, is this a toolkit autocomplete issue?  
Elliot, excellent report. Thanks.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Mark, is this a toolkit autocomplete issue?  

We haven't fully swapped to toolkit autocomplete yet. I doubt changing the backend would have affected it, but it could be a fault in the xpfe widget, cc'ing Neil as he may know better.

Comment 3

[[e-mail]]

Attachment: Possible patch

This happens because when we blur we try to complete, and because the last search string was empty we don't clear the results and instead we complete the previous results.

This patch works by clearing the results when the search string is empty. (Toolkit always clears the results when the search string gets shorter.)

Comment 4

[[e-mail]]

Pushed changeset 785106e4b4cd to mozilla-central.

Comment 5

[[e-mail]]

Pushed changeset 785106e4b4cd to mozilla-central.

Comment 7

[Thomas D. (:thomas8)]

The specific case of this bug has been fixed (undesired autocomplete contacts are reinstated after *completely* deleting user input and suggestions), but much of the same problem remains (if you delete only the suggestion and/or only parts of the input), as pointed out by similar Bug 470656 -  Autocomplete reinstates undesired to-recipient contacts, e.g. after cursor left or DEL (can't delete suggested email address).

Bug 470656 suggests using the Firefox awsomebar approach to fix this properly, as does bug 464914 comment #7: Have autocomplete list BELOW the input field rather than interfere with input.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ff48fcec876b
Clear autocomplete results when the search string is empty r=Standard8