Closed Bug 457832 Opened 13 years ago Closed 13 years ago

Going into offline mode marks a running download as finished

Categories

(Core :: Networking: HTTP, defect)

1.9.0 Branch
defect
Not set
critical

Tracking

()

VERIFIED WONTFIX

People

(Reporter: Lukas_krs, Assigned: jduell.mcbugs)

References

()

Details

(Keywords: dataloss)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3

I noticed that firefox 3 doesn't give any warning about current active download when I went to offline mode. The result is that the download (of a flv file) is stopped without any confirmation. And I need to download the whole file again because the browser assume the file was completely downloaded. It's gonna be great if firefox 3 give us a confirmation about stopping current active download when firefox goes to offline mode, like what they did in firefox 2.

Reproducible: Always

Steps to Reproduce:
1. Download a file (maybe an flv).
2. Go to offline mode while download still in progress.
Actual Results:  
Download automatically stopped without any warning

Expected Results:  
It warns user about current active download
Version: unspecified → 3.0 Branch
Component: General → Download Manager
Product: Firefox → Toolkit
QA Contact: general → download.manager
Version: 3.0 Branch → 1.9.0 Branch
While running the smoketests for the upcoming 3.0.6 build, I've seen this behavior too. Downloading a large file, e.g. Ubuntu and switching into offline mode marks running downloads as finished. They cannot be resumed and you have to start the download again.

Steps:
1. Ensure you stay online
2. Open http://www.ubuntu.com/getubuntu/download
3. Start the download of an Ubuntu release
4. Open the download manager
5. Switch into offline mode by choosing "File | Work Offline"

With step 5 all running downloads are stopped.

Further I've seen that we have some inconsistencies with two prefs we are using: "browser.offline" vs. "network.online". Selecting the menu item I always get following error:

Error: this._uiElement is null
Source file: chrome://browser/content/browser.js
Line: 5138

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#5280

No idea if this is a separate issue. Shawn, do you have any ideas?
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.9.1?
Keywords: dataloss
OS: Windows XP → All
Hardware: x86 → All
Summary: Work offline didn't give warning on stop downloading → Going into offline mode marks a running download as finished
Is the download normally pauseable?
Yes, for that case its pauseable. But if it wouldn't be, we should better give a warning and cancel the download if confirmed by the user.
Looking at the download manager code, I don't see anything that would cause this behavior, so I suspect this has something to do with necko.
Component: Download Manager → Networking: HTTP
Product: Toolkit → Core
QA Contact: download.manager → networking.http
Not sure this is a blocker, but it's clearly a usability issue, and I'll try to get to it soon.
Assignee: nobody → mr.mcbugs
Status: NEW → ASSIGNED
Given how few people seem to see this bug, and based on a discussion with sdwilsh and jduell, we won't be blocking on this. If there's more data to share here that makes it more clear what's going on (i.e. os versions, network connection type, and the like), then please speak up and renominate.
Flags: blocking1.9.1? → blocking1.9.1-
This bug is only valid for the 1.9.0 branch and it doesn't occur on 1.9.1 and trunk. Looks like that one of the download manager fixes which weren't checked into 1.9.0 yet, fixed that for FF3.1.

No idea if it qualifies for 1.9.0. If not it should better marked as WONTFIX.
The bar for what goes in centers on regressions, security fixes, and top crashers. If this bug has always been present in 1.9.0 and is fixed in 1.9.1, it probably doesn't meet the bar.
Yes, its already present in FF3.0. I leave it up to you to close it.
Yeah, not going to fix this on 1.9.0.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.