DOMi fails to load main application when -inspector flag is used

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I use use DOMi to debug xul applications by passing the -inspector flag on the commandline when starting the app. This fails to load the actual application window because DOMi's commandline handler prevents the default action:

http://hg.mozilla.org/dom-inspector/file/2bae5150d746/base/js/inspector-cmdline.js#l103

This was introduced in bug 340233. Simply removing the line of code allows DOMi and the application to load.
Created attachment 341268 [details] [diff] [review]
patch

This patch simply removes the code to prevent the default command line action
Assignee: nobody → mark.finkle
Attachment #341268 - Flags: review?(sdwilsh)
Attachment #341268 - Flags: superreview?(neil)
Attachment #341268 - Flags: review?(sdwilsh)
Attachment #341268 - Flags: review?(neil)
Attachment #341268 - Flags: review+
Comment on attachment 341268 [details] [diff] [review]
patch

r=sdwilsh

Neil added this, so he should certainly take a look at this too.

Updated

10 years ago
Attachment #341268 - Flags: superreview?(neil)
Attachment #341268 - Flags: superreview+
Attachment #341268 - Flags: review?(neil)
Attachment #341268 - Flags: review+
http://hg.mozilla.org/dom-inspector/rev/033072f5b21d
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Blocks: 457254

Comment 4

10 years ago
How about something like <http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/jsconsole-clhandler.js#63>

if (cmdLine.state == Ci.nsICommandLine.STATE_REMOTE_AUTO)
  cmdLine.preventDefault = true;

FYI: The error console command line handler checks for an existing window and focuses on it if found.
You need to log in before you can comment on or make changes to this bug.