Closed Bug 457906 Opened 16 years ago Closed 16 years ago

browser.cache.disk.capacity is incorrectly calculating MBs

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.1b2

People

(Reporter: mkmelin, Assigned: mkmelin)

References

()

Details

Attachments

(1 file)

Attached patch proposed fixSplinter Review
Under Advanced | Network, there is UI to set the size of browser.cache.disk.capacity. The calculation of this wrongfully converts KiB to MiB by multiplying by 1000. (Should be 1024.)

Though MB is a bit ambiguous, it's only calculated like that for floppy disks.

The pref in http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/src/init/all.js#62 is correctly set to 50 MB, but in firefox.js it's not.

Since the corrected pref is the same as the default we can just remove it.
Attachment #341139 - Flags: review?(gavin.sharp)
Attachment #341139 - Flags: review?(gavin.sharp) → review+
changeset:   20336:5dc812c08c30
http://hg.mozilla.org/mozilla-central/rev/5dc812c08c30

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: