457979 - TM: Random failures on Windows

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andreas Gal :gal]

We pass TUnit+Mochi on MacOSX.

However, we seem to have random crashes on Windows and Linux.

Comment 1

[Andreas Gal :gal]

Symptoms: test fails when run as part of the mochi suite or as part of a group of tests. Re-executing the same test succeeds within the same browser.

We also seem to trigger an iloop in the ajax/offline test. That is supposedly not related to us and can be worked around as follows:

stuart: 21:47 <campd> dom/tests/mochitest/ajax/offline/offlineTests.js
[7:13pm] stuart: 21:47 <campd> in waitForAdd()
[7:13pm] stuart: 21:47 <campd>      var entry = cacheSession.openCacheEntry(url, Ci.nsICache.ACCESS_READ, true);
[7:13pm] stuart: 21:47 <campd> that last arg should be false

Comment 2

[Stuart Parmenter]

Attachment: verbose tracemonkey output from my run

this is the output I got from my run through the prototype test... not sure if it is useful or not.. i cut off the log after the test failed.

Comment 3

[Andreas Gal :gal]

According to Graydon we pass Linux except for two failures that also happen on m-c (something about widgets and pixels). That leaves Windows.

Comment 4

[Andreas Gal :gal]

Attachment: Check shape after making sure its actually a native object.

Comment 5

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/b448ac318d34

Comment 6

[Andreas Gal :gal]

TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 8443 bytes during test execution (should have leaked no more than 0 bytes)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 4 instances of AtomImpl with size 16 bytes each (64 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 3 instances of StringAdopt with size 1 bytes each (3 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of ThreadShutdownObserver with size 12 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of mozStorageConnection with size 72 bytes each (144 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of mozStorageService with size 24 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 6 instances of mozStorageStatement with size 40 bytes each (240 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsAccessControlLRUCache with size 40 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 9 instances of nsAccessControlLRUCache::CacheEntry with size 28 bytes each (252 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsBaseURLParser with size 8 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 48 instances of nsCStringKey with size 16 bytes each (768 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsCategoryObserver with size 56 bytes each (112 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsChannelToPipeListener with size 40 bytes each (80 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsCookiePermission with size 32 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsCookieService with size 96 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsDNSService with size 40 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsEffectiveTLDService with size 44 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 48 instances of nsHashKey with size 4 bytes each (192 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsHashPropertyBag with size 44 bytes each (88 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 4 instances of nsHashtable with size 44 bytes each (176 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsHttpChannel with size 432 bytes each (864 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsHttpConnectionInfo with size 40 bytes each (80 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsHttpHandler with size 340 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsIDNService with size 60 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsIOService with size 120 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsLocalFile with size 88 bytes each (176 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsNotifyAddrListener with size 176 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsObserverService with size 44 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsPermissionManager with size 96 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsPipe with size 152 bytes each (304 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsPrefBranch with size 52 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsPrincipal with size 72 bytes each (144 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsSocketTransportService with size 1672 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 4 instances of nsStandardURL with size 172 bytes each (688 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsStreamConverterService with size 12 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 94 instances of nsStringBuffer with size 8 bytes each (752 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 25 instances of nsTArray_base with size 4 bytes each (100 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsThreadPool with size 56 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsUnicodeNormalizer with size 8 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsVariant with size 56 bytes each (112 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 28 instances of nsVoidArray with size 4 bytes each (112 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 5 instances of nsWeakReference with size 12 bytes each (60 bytes total)

Tinderbox completed but we failed the leak test. Not sure how or why.

Comment 7

[Andreas Gal :gal]

Our tinderbox is now officially green! 

The memory leaks were caused by a patch by doublec that was backed out moments after we synced mc into TM. I synced again and that made it go away.

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1222847186.1222851875.11647.gz

Comment 8

[Brendan Eich [:brendan]]

Sorry for the bug, I can't believe it "worked" on non-Windows platforms.

/be

Comment 9

[Aakash Desai [:aakashd]]

Seeing as there hasn't been any discussions about this bug for 5 months, I'm
guessing there aren't any residual issues. I'm moving this to verified as a
result. If anyone has any qualms, feel free to bring them up.