458015 - Add return values check to set_freebl() in memleak.sh.

Status: RESOLVED FIXED

(NSS :: Test, defect, P3)

Description

[Slavomir Katuscak]

In memory leak tests we use various FreeBL libaries and in testing with non-default library, we copy libraries to temporary directory and set it as library directory. 

Sometimes (usually when there are some build synchronization problems) it fails:
---
memleak.sh: Using libfreebl_32int_3 instead of libfreebl_32fpu_3
mv: cannot access /share/builds/mccrel3/security/securityjes5/builds/20080929.1/wozzeck_Solaris8/mozilla/tests_results/security/simplify.5/tmp19769/libfreebl_32fpu_3.so
cp: cannot access /share/builds/mccrel3/security/securityjes5/builds/20080929.1/wozzeck_Solaris8/mozilla/tests_results/security/simplify.5/tmp19769/libfreebl_32int_3.so
mv: cannot access /share/builds/mccrel3/security/securityjes5/builds/20080929.1/wozzeck_Solaris8/mozilla/tests_results/security/simplify.5/tmp19769/libfreebl_32fpu_3.chk
cp: cannot access /share/builds/mccrel3/security/securityjes5/builds/20080929.1/wozzeck_Solaris8/mozilla/tests_results/security/simplify.5/tmp19769/libfreebl_32int_3.chk
---

In function set_freebl() in memleak.sh we don't check for return values of cp/mv, so those failures are not detected automatically. Adding return value check to cp/mv commands would help.

Comment 1

[Slavomir Katuscak]

Attachment: Patch v1.

Added return values check + removed <TR><TD> from old html_failed calls (already added directly to html_failed function).

Comment 2

[Christophe Ravel]

Comment on attachment 341266 [details] [diff] [review]
Patch v1.

r+=christophe

Comment 3

[Slavomir Katuscak]

3.12.x:
Checking in memleak.sh;
/cvsroot/mozilla/security/nss/tests/memleak/memleak.sh,v  <--  memleak.sh
new revision: 1.29; previous revision: 1.28
done

3.11.x:
Checking in memleak.sh;
/cvsroot/mozilla/security/nss/tests/memleak/memleak.sh,v  <--  memleak.sh
new revision: 1.1.2.20; previous revision: 1.1.2.19
done