458017 - Increment Fennec BuildID separately

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Antonio Gomes (tonikitoo)]

Attachment: xml parser error 1

run a raw build from tonight's tip (rev 214:5f94200eb710).

prefs xbl's seems problematics. 

see sshot 1 and 2.

Comment 1

[Antonio Gomes (tonikitoo)]

Attachment: xml parser error 2

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

This sounds like fallout from bug 455145. I saw similar errors. The problem was the XUL cache in my profile. The BUILDID of Fennec wasn't being bumped up in my test, so the cache was stale. Deleting my profile "fixed" the problem. Another way to fix the problem is to get the BUILDID in application.ini bumped up.

Let me know if that fixes things for you.

Comment 3

[Daniel Brooks [:db48x]]

I don't see this problem at all. preferences.dtd is there, and it doesn't appear to be missing anything: http://hg.mozilla.org/mobile-browser/file/5f94200eb710/locales/en-US/chrome/preferences.dtd

Comment 4

[Antonio Gomes (tonikitoo)]

works after a clobber build.

invalid.

Comment 5

[Niranjan]

What is a clobber build?

I just did the fennec update and I am getting the XML parsing error in chrome://browser/content/browser.xul ?

Comment 6

[Stuart Parmenter]

Niranjan: a clobber build is just basically deleting your objdir or running make distclean and rebuilding... as opposed to a depend build.  Something isn't getting rebuilt correctly

Comment 7

[Niranjan]

It works after making a fresh build.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

I'm reopening after seeing something similar

> XML Parsing Error: undefined entity
> Location: chrome://browser/content/browser.xul
> Line Number 96, Column 5:    <command id="cmd_openLocation" label=" openLocation.label;" oncommand="CommandUpdater.doCommand(this.id);"/>
> ----^

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

deleting my profile fixed the problem, sounds like mark was right in comment #2.  It would still be nice to get this fixed.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Switch to an app-specific build-id and not a GRE build-id. Similar code was added to other XULRunner apps, especially where the SDK is used to build.

Now anytime the app is rebuilt and XR doesn't, we still increment the buildid in application.ini

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Should we use make-platformini.py --print-buildid instead, to match what xulrunner does? Not sure how portable that date call is...

http://mxr.mozilla.org/mozilla-central/source/config/Makefile.in#116

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This one uses make-platformini.py --print-buildid

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 350719 [details] [diff] [review]
patch 2

>diff --git a/app/Makefile.in b/app/Makefile.in

>-DEFINES += -DGRE_MILESTONE=$(GRE_MILESTONE) -DGRE_BUILDID=$(GRE_BUILDID) -DAPP_NAME=$(MOZ_APP_DISPLAYNAME)
>+DEFINES += -DGRE_MILESTONE=$(GRE_MILESTONE) -DGRE_BUILDID=$(GRE_BUILDID)  -DAPP_BUILDID=$(APP_BUILDID)

nit: extra space

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

removed extra space

http://hg.mozilla.org/mobile-browser/rev/29cf79de7ea5

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

verified with beta4