458075 - thunderbird-bin shouldn't try and link directly with libtracemalloc anymore

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Philippe M. Chiasson (:gozer)]

Attachment: [checked in] Don't try and directly link with tracemalloc anymore

As part of work on bug 435122, the need for the final executable to link directly to libtracemalloc has been removed.

The side effect of this change is that when building Thunderbird with --enable-shared, generating thunderbird-bin tries to link with -ltracemalloc, and that will fail. With static builds, we just end up double-linking against tracemalloc.

Attached patch simply removes the special case for libtracemalloc

Sunbird suffers from a similar problem.

Comment 1

[Robert Kaiser]

Comment on attachment 341298 [details] [diff] [review]
[checked in] Don't try and directly link with tracemalloc anymore

I've never built with tracemalloc, so I don't actually know much about this, but I believe you saying it fails (your comment is wrong about static though as this is in a non-static-only ifdef).

Comment 2

[Philippe M. Chiasson (:gozer)]

The code goes like shis: 

ifndef BUILD_STATIC_LIBS

/* So we don't have --enable-static (i.e. --enable-shared)

ifdef NS_TRACE_MALLOC

/* We have --enable-tracemalloc

EXTRA_DSO_LIBS += tracemalloc

/* Here we explicitely expect to be able to link to a *dynamic* library called tracemalloc, boom! */

Basically, there is never going to be a libtracemalloc.so anymore, when enabling tracemalloc, it just ends up statically linked inside the guys of XPCOM somewhere, so no clients of tracemalloc need special linking with it.

Comment 3

[Philippe M. Chiasson (:gozer)]

Comment on attachment 341298 [details] [diff] [review]
[checked in] Don't try and directly link with tracemalloc anymore

changeset:   569:a3db346b2e2a
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Thu Oct 09 16:33:53 2008 -0400
summary:     Bug 458075. It's not necessary (and a bug, actually) to link against libtracemalloc directly anymore. r=KaiRo