Kill VISUALSELECTION code

RESOLVED FIXED in mozilla1.9.1b2

Status

()

Product:
Core
Component:
Selection
Type:
defect
Importance:
--
trivial
Status:
RESOLVED FIXED
Reported:
11 years ago
Modified:
11 years ago

People

(Reporter: uriber, Assigned: uriber)

Tracking

Version:
Trunk
Target:
mozilla1.9.1b2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch
19.05 KB, patch
smontagu
: review+
roc
: superreview+
Details | Diff | Splinter Review
Assignee

Description

•
11 years ago 
The code guarded by #ifdef VISUALSELECTION has been dead for years now. If visual bidi selection is to ever be resurrected (which I highly doubt), the code will likely have to be written from scratch anyway (see bug 195909).

Maintaining (or pretending to maintain) this code is time-consuming and annoying. Let's just kill it off.
Assignee

Comment 1

•
11 years ago
Posted patch patch — — Splinter Review
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #341307 - Flags: superreview?(roc)
Attachment #341307 - Flags: review?(smontagu)
Attachment #341307 - Flags: review?(smontagu) → review+
Attachment #341307 - Flags: superreview?(roc) → superreview+
 Assignee

Comment 2

•
11 years ago 
Fixed with changeset 335b63a03aba.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.