Closed
Bug 458114
Opened 17 years ago
Closed 17 years ago
Add attached js to /en-US/products/download.html
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bcutler, Assigned: clouserw)
References
()
Details
Attachments
(2 files)
|
1.11 KB,
text/plain
|
Details | |
|
550 bytes,
patch
|
Details | Diff | Splinter Review |
In order to track conversions with Omniture, we need to place the attached js on the en-US download page.
|
Reporter | |
Comment 1•17 years ago
|
||
|
||
Comment 2•17 years ago
|
||
Any update here? Can this be assigned?
We have some time dependencies here.
Severity: normal → major
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 341338 [details]
Diff File
Putting a <div> in the <head> isn't valid so I won't commit that.
When we put mbox.js on mozilla.com I asked that it be added to the footer of the pages it is used on. Is there a reason that won't work?
|
|
Reporter | |
Comment 4•17 years ago
|
||
I believe that the js mbox script has to go in the <head> in order to function properly. The <div> can go anywhere.
|
|
Assignee | |
Comment 5•17 years ago
|
||
(In reply to comment #4)
> I believe that the js mbox script has to go in the <head> in order to function
> properly. The <div> can go anywhere.
Is there any documentation for that? In my testing it works fine in the footer. ("fine" being nothing breaks - I don't know what your goal is here)
|
|
Reporter | |
Comment 6•17 years ago
|
||
The documentation is available here: http://www.stanford.edu/~bcutler/integration.pdf. The js just needs to be placed above the <div>, so you can put both the js and the <div> in the footer.
|
|
Assignee | |
Comment 7•17 years ago
|
||
It's difficult for me to help you when you don't explain what you're trying to do. I suspect that you don't actually want the <div> in the footer so I'm proposing the attached. If you do actually want it there I can do that instead. What do you think of the attached?
Assignee: nobody → clouserw
|
|
Assignee | |
Comment 8•17 years ago
|
||
By the way, the $extra_footers are placed directly above the </body>
|
|
Reporter | |
Comment 9•17 years ago
|
||
Sorry about the lack of clarity--I'm still trying to figure all of this out. The changes look good.
|
|
||
Comment 10•17 years ago
|
||
Wil and Blake -- what's the status here?
|
|
Assignee | |
Comment 11•17 years ago
|
||
I was waiting to commit at the same time as 457993 but this is r18974 now.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Verified FIXED on https://www-trunk.stage.mozilla.com/en-US/products/download.html:
</div> <!-- end #download_message -->
<div class="mboxDefault"></div>
<script type="text/javascript" src="/js/mbox.js"> </script>
<script type="text/javascript">
mboxCreate('conversion');
</script>
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: PC → All
|
||
Updated•13 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
|
|
||
Updated•13 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•