458138 - Remove Flash Player from the Plugin Finder Service for FF2 Vista clients

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[John Pfeiffer]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16

The delivery of the Flash Player via PFS to Vista FF2 clients is broken, but the FF2 Vista client still has to wait for the xpi installer to be downloaded. This Vista user experience would be improved if the FPS did not download the Flash Player xpi (just display the Manual download button).

Reproducible: Always

Steps to Reproduce:
1. Uninstall the Flash Player.
2. Navigate FF2 to Flash content.
3. Click on the puzzle piece to install the Flash Player.
Actual Results:  
PFS download the Flash xpi then report an installation failure and provides the manual download button.

Expected Results:  
Do not download the xpi, just display the manual download button.

Comment 1

[Michael Morgan [:morgamic]]

Attachment: v1, removes XPI offering for firefox2 on vista

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 343012 [details] [diff] [review]
v1, removes XPI offering for firefox2 on vista

The tests pass as expected.

Comment 3

[Michael Morgan [:morgamic]]

r19070

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

morgamic: what do I change |pfs.datasource.url| to, in order to test this?

Comment 5

[Michael Morgan [:morgamic]]

https://wiki.mozilla.org/PFS#Testing_PFS

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, morgamic; <3.

Verified FIXED;

Test URL: http://www.macromedia.com/software/flash/about/
Client: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.17) Gecko/2008082909 Firefox/2.0.0.17

Steps to Reproduce:

1. Visited the above URL with Firefox 2.0.0.17 on Vista and |pfs.datasource.url| set to https://pfs.mozilla.org/plugins/PluginFinderService.php?mimetype=%PLUGIN_MIMETYPE%&appID=%APP_ID%&appVersion=%APP_VERSION%&clientOS=%CLIENT_OS%&chromeLocale=%CHROME_LOCALE%&appRelease=%APP_RELEASE%

* I get a "Downloading Adobe Flash Player" status text/bar, with a "Failed" status next to the "Manual Install" button.

2. Visited the same URL with Firefox 2.0.0.7, but this time I set |pfs.datasource.url| to https://preview.addons.mozilla.org/services/pfs.php?mimetype=%PLUGIN_MIMETYPE%&appID=%APP_ID%&appVersion=%APP_VERSION%&clientOS=%CLIENT_OS%&chromeLocale=%CHROME_LOCALE%&appRelease=%APP_RELEASE%

* It no longer tries to install, and instead--after clicking "I agree" to the EULA, puts up "Not Available" next to the "Manual Install" button.

Comment 7

[Michael Morgan [:morgamic]]

Hrm, this is wrong -- shouldn't have to agree to EULA.  I'll remove the EULA stuff for Vista as well.

Comment 8

[Michael Morgan [:morgamic]]

Attachment: v2, also removes the licenseURL to avoid the EULA dialog

Comment 9

[Fred Wenzel [:wenzel]]

Comment on attachment 343012 [details] [diff] [review]
v1, removes XPI offering for firefox2 on vista

The new patch doesn't render obsolete this one.

Comment 10

[Fred Wenzel [:wenzel]]

Comment on attachment 343107 [details] [diff] [review]
v2, also removes the licenseURL to avoid the EULA dialog

Yup, that works.

Comment 11

[Michael Morgan [:morgamic]]

Thanks, fred - r19100.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; EULA is now gone.