layout ignores image attributes for added images

VERIFIED FIXED in M4

Status

()

Core
Layout
P3
normal
VERIFIED FIXED
19 years ago
18 years ago

People

(Reporter: Akkana Peck, Assigned: Akkana Peck)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Assignee)

Description

19 years ago
When an image is added in the editor (Insert->Image), layout ignores the width,
height, and alignment for that image, although those attributes correctly go
into the dom.

To reproduce:
apprunner -editor
Click somewhere
Insert->image
  (This is currently hardwired to insert
http://www.mozilla.org/editor/images/pensplat.gif, width 100, height 138,
alignment left, border 1)
Notice that the image gets inserted but text doesn't flow around it and there's
no border.
Click somewhere else
Insert->image again
Notice that the second time, the image is drawn very small, not at the right
width and height, and again the alignment isn't done right.

Now do Debug->Output HTML and notice that the attributes are all stored
correctly in the dom.  copy/paste this output into a file (or use mine, see URL
field) and bring up the file in apprunner's browser mode.  Notice that this time
it's drawn right; it's only on images inserted after the rest of the document is
loaded that the image attributes are ignored.

Haven't tried this on anything but Linux yet.

Updated

19 years ago
Assignee: troy → akkana

Comment 1

19 years ago
Akkana, I built apprunner and tested it as you suggestd, but I can't tell what
Insert->Image does so it's very difficult to diagnose. It doesn't help that
apprunner doesn't have viewer's Debug|Dump Content and Debug|Dump Frames menu
items

The way we test this sort of stuff in layout is by having JavaScript code that
does the incremental operation. If you have that, then I can tell what is
actually happening and I can run it in viewer.exe
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

19 years ago
I think this may have gone away by the rewrite of insert image to set all the
attributes before inserting into the document; but we won't know for sure until
we get the image attribute dialog working.

I'm going to close this bug for now, and reopen it if necessary when we get the
dialogs going.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 3

18 years ago
setting to an approximate milestone so it can be off of the no TFV list
Target Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.