458304 - Implement pref listener for ad-blocking

Status: RESOLVED WONTFIX

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Chris Lawson (gone)]

From bug 369878:

Certain preferences (adblocking, flashblock) rely on notifications from the
preference pane to load and unload their associated stylesheets. What this
means is that these prefs can only be changed via the pref panes -- changing
them from about:config does nothing.

STR:

1. Make sure adblocking is enabled
2. Visit a site with ads (http://nytimes.com)
3. go to about:config, change camino.enable_ad_blocking to false
4. Reload

AR: No ads displayed.

ER: Ads displayed.

Filing as UNCO, because we might just decide we don't care enough to bother with it.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Honestly, I don't think we care; no one in their right mind is going to change ad-blocking in about:config.

The places where we would want to make sure about:config works are places where we don't expose all possible values in our UI (e.g., SWM, tabfocus) or places where our prefs UI is sub-optimal (e.g., before bug 346209 was fixed, I used to change font prefs in about:config when testing things because it was far quicker to type in a name and repeat than to select a font, switch panes, and repeat).  To my knowledge, all of those sorts of places do work.

Comment 2

[Chris Lawson (gone)]

I'm fine with that reasoning; WONTFIXing.