458398 - Need to hook changing filesystem permissions

Status: RESOLVED DUPLICATE of bug 644334

(Bugzilla :: Extensions, enhancement)

Description

[Greg Hendricks]

Testopia needs to add to the list of files that checksetup examines and changes permissions on. 

Bugzilla/Install/Filesystem.pm

Comment 1

[Frédéric Buclin]

Bugzilla 3.2 is restricted to security bugs only. Moreover, this bug is either assigned to nobody or got no traction for several months now. Rather than retargetting it at each new release, I'm clearing the target milestone and the bug will be retargetted to some sensible release when someone starts fixing this bug for real (Bugzilla 3.8 more likely).

Comment 2

[Gervase Markham [:gerv]]

I'd agree with this. I've written several extensions which have a bin/ directory with scripts in, and it's a pain that they keep having their execute permissions removed when I run checksetup.pl.

mkanat, LpSolit: any quick guidance on what sort of interface such a hook would have? Do we just pass in all the hashes and let extensions add to them? Or is there a better way?

Gerv

Comment 3

[David Lawrence [:dkl]]

(In reply to Gervase Markham [:gerv] from comment #2)
> I'd agree with this. I've written several extensions which have a bin/
> directory with scripts in, and it's a pain that they keep having their
> execute permissions removed when I run checksetup.pl.
> 
> mkanat, LpSolit: any quick guidance on what sort of interface such a hook
> would have? Do we just pass in all the hashes and let extensions add to
> them? Or is there a better way?
> 
> Gerv

I fixed this in the BMO version of extensions/RequestWhiner here:

http://bzr.mozilla.org/bmo/4.0/annotate/head:/extensions/RequestWhiner/Extension.pm

using the install_filesystem hook. It sets the execute bit whenever checksetup.pl
is ran. Its in bugzilla/extensions/requestwhiner as well.

I plan on

Comment 4

[Frédéric Buclin]

Per dkl's comment 3, it seems the install_filesystem hook is enough to do this, right? (aka WFM)

 http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/Hook.html#install_filesystem

Comment 5

[David Lawrence [:dkl]]

Yes. We can close this as FIXED as when this was filed, install_filesystem did not exist.

dkl

Comment 6

[Gervase Markham [:gerv]]

Yep; and it doesn't exist in the version I'm currently writing an extension for, which is why I didn't find it. Thanks, guys :-)

Gerv