Closed Bug 458489 Opened 14 years ago Closed 14 years ago

We should only zoomToPage when the main document finishes loading

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: pavlov, Assigned: pavlov)

Details

Attachments

(1 file)

Right now we're calling updateCanvasState/translatePhoneNumbers/etc every time any document (think iframes) finishes loading.  this results in us zooming and redrawing the visible area.  for sites with lots of iframes this kills performance.
Flags: blocking-fennec1.0+
Attached patch fixSplinter Review
Attachment #341733 - Flags: review?(gavin.sharp)
Comment on attachment 341733 [details] [diff] [review]
fix

r=me with:
s/sub-iframes/sub-frames/
last comment removed
Attachment #341733 - Flags: review?(gavin.sharp) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
we have redone the zooming and in general we don't zoom until the page is loaded.

verified with 1.9.2 20091001 beta4 on my n810
Status: RESOLVED → VERIFIED
We need a new negative regression testcase that gets the user to try to perform a zoom while the page is loading. Let's add this to the screen navigation subgroup.
Flags: in-litmus?
Component: General → Panning/Zooming
litmus testcase: https://litmus.mozilla.org/show_test.cgi?id=11531 has been created to regression test this bug.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.