458562 - Audit front-end code for unnecessary try/catch blocks

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Description

[Joey Minta]

Attachment: patch v1

There are a lot of places where large chunks of code are kept in try/catch blocks, and errors are either swallowed or dump()ed.  As a mac hacker, this can make errors easy to miss, and difficult to track down, because dump() does not end up in an easily viewable place. More importantly, these try/catch blocks can mask other errors, or hurt performance. This patch removes most of the obviously unncessary blocks.

This patch looks bigger than it actually is, since removing a try/catch almost always requires adjusting whitespace. I haven't yet figured out how to force hg to give me a -w patch.

Comment 1

[Phil Ringnalda (:philor)]

In mailWindowOverlay.js::MsgFilters - gDBView.hdrForFirstSelectedMessage throws NS_ERROR_UNEXPECTED if there's a folder selected, but no message selected (select an empty folder then Tools - Message Filters is the easiest way to repro).

Comment 2

[Phil Ringnalda (:philor)]

As does the gDBView.URIForFirstSelectedMessage in msgMail3PaneWindow.js::GetLoadedMessage

Comment 3

[Phil Ringnalda (:philor)]

Error: treeView.selection is null
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 1291

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 341786 [details] [diff] [review]
patch v1

Not going to be quite that easy.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #0)
> This patch looks bigger than it actually is, since removing a try/catch almost
> always requires adjusting whitespace. I haven't yet figured out how to force hg
> to give me a -w patch.

hg diff -w is meant to work, but it seems it doesn't work for everyone. So, in your .hgrc file, to the [extensions] section add:

hgext.extdiff =

Then add a new section (if it isn't there already):

[extdiff]
cmd.diffw = diff
opts.diffw = -NprwU8

Use the options that you prefer the most. You'll then have a new command 'hg diffw'

Comment 6

[Wayne Mery (:wsmwk)]

Is this still worth a look?

Comment 7

[Magnus Melin [:mkmelin]]

Perhaps yes. There are some pieces there that are likely still useful.