Open Bug 458563 Opened 12 years ago Updated 9 years ago

Add tag soup html parser tests to mochitest suite

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set

Tracking

()

People

(Reporter: mats, Unassigned)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

Add tag soup html parser tests to mochitest suite.
Attached patch Patch rev. 1Splinter Review
Result: 274 pass / 0 fail / 15 todo on all three tier-1 platforms.

The todo-cases failed for various reasons, mostly because the test
framework (the html5_tree_construction parsing stuff) bailed on them.
I also had to dumb down a few of the pass-cases to make them pass but
I think these tests are still faithful to the original test objective.
(the attribute matching stuff in the framework is buggy)

I did a couple of minor code changes in "parser_datreader.js":
I made ## at the beginning of a line be ignored (aka "comment").
I made ##todo special in that it also calls Mochitest todo() with the
remainder of the line.
Attachment #341796 - Flags: review?(dbaron)
Any reason you picked me as a reviewer?  mrbkap owns the parser; other people are more familiar with mochitest than I am.
No reason, just picked the first name that popped up in my (admittedly tired) brain at the time ;-)
Attachment #341796 - Flags: review?(dbaron) → review?(mrbkap)
Attachment #341796 - Flags: superreview+
Attachment #341796 - Flags: review?(mrbkap)
Attachment #341796 - Flags: review+
Comment on attachment 341796 [details] [diff] [review]
Patch rev. 1

Looks good overall. File a followup on figuring out why parser_datreader.js can't grok some of the tests.
Attached patch Patch rev. 2 (obsolete) — Splinter Review
Made a couple of minor tweaks to the tests to make it pass locally.
This made Tinderbox orange :-(  I'm trying to push a bustage fix but
hg.mozilla.org is having issues it seems: 

remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: error: pretxnchangegroup.z_linearhistory hook raised an exception: database is locked
remote: transaction abort!
remote: rollback completed
remote: ** unknown exception encountered, details follow
Ok, thanks.
Depends on: 462701
Filed bug 462701 on parser_datreader.js, we need to fix that before
this lands.
Attachment #345894 - Attachment description: Patch rev. 2 (landed) → Patch rev. 2
Attachment #345894 - Attachment is obsolete: true
Assignee: matspal → nobody
You need to log in before you can comment on or make changes to this bug.