458572 - add icons to the imip-bar buttons

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), enhancement)

Description

[Przemyslaw Bialik]

Add icons to the imip-bar buttons (accept, decline, tentative etc.).

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Note that Dan pointed out it would be nice to move the imip bar to using a <notificationbar> in bug 372424. This could possibly make that step easier.

Otherwise its just a matter of adding some styles and maybe classes. We'd also need UI for this (and a decision if its really wanted)

Comment 2

[Mark Capella [:capella]]

Adding new contributor and pointing him to the mentor....

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hi LenoirINT! I'm excited you've decided to tackle this bug and am glad to help out. First of all, we will need some icons:

* One icon per button, obviously
* There are certain platform differences so: different icon per platform
* Windows is split up in windows-aero and classic so this needs separate icons too

Its possible that we could re-use either our own icons or Thunderbird icons, this needs to be investigated. In case we do need new icons, how are you with icon design? I've CC'd some of the Thunderbird UI Folks that may be able to help out in case you're not so much into graphics design.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: proposal

Quick hack to show how it could look.
Maybe the icons from calendar-invitations-dialog-button-images.png could be used to accept or decline. This would be consistent with the Attendee dialog. For the Tentative button i created a icon with the same color (rgb(21, 137, 255)) the Attendee dialog uses to show the tentative state.

For XP and Linux this could be done like this. Aero and OSX are now using monochrome icons. Should we also use monochrome icons for the IMIP bar for this systems? The screenshot is made on Win7 and shows how the mixture would look.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I think we should not mix icon styles.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: IMIP icons for Aero

I created icons for Aero.
What do you think about them?

Comment 7

[Richard Marti (:Paenglab)]

Attachment: IMIP icons for OSX

And icons for OSX

Comment 8

[Stefan Sitter [:ssitter]]

I agree that the icon style should match the icon style that is used by Thunderbird in the message preview pane. Regarding the icon picture I'd use the 2nd proposal using check mark, "x" and "?". The "?" looks out of place / inverted compared to the other images because it is white on black compared to black on white. How would a black "?" without the background look on the buttons?

Comment 9

[Richard Marti (:Paenglab)]

Attachment: IMIP icons for Aero alternative

The first icon came from chat toolbar, but was a exclamation mark with the same withe.

I think this approach looks now better.

Comment 10

[LenoirINT]

(In reply to Richard Marti [:paenglab] from comment #9)
> Created attachment 646211 [details]
> IMIP icons for Aero alternative
> 
> The first icon came from chat toolbar, but was a exclamation mark with the
> same withe.
> 
> I think this approach looks now better.

I like these icons above. I also do graphics but as this is my first bug I am having a hard enough time just dealing with the request to add these in. So thank you to those who are helping with the graphics and giving feedback.

Comment 11

[Mike Hoye [:mhoye]]

Can you confirm that you're still working on this bug?

Comment 12

[Richard Marti (:Paenglab)]

Attachment: patch

Patch gives the imip buttons icons.

On Linux I tried to use GTK-icons but found no one for Tentative which fits well. Now I used the XP icons.

Comment 13

[Richard Marti (:Paenglab)]

Attachment: screenshot with patch applied

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Does this work out when the imip buttons have other actions? They can have different meanings depending on the imip action.

Comment 15

[Richard Marti (:Paenglab)]

The css differentiates only between imip-button1, imip-button2 and imip-button3. If this isn't enough I could try to add a class or something else.

What other actions could this three button-IDs have?

Comment 16

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Button 1 can be:
  - Details…         (imipDetails.label)
  - Update           (imipUpdate.label)
  - Add To Calendar  (imipAddToCalendar.label)
  - Accept           (imipAcceptInvitation.label)
  - Cancel           (imipCancelInvitation.label)
  - Send             (imipSend.label)

Button 2 can be:
  - Decline          (imipDeclineInvitation.label)

Button 3 can be:
  - Tentative        (imipAcceptTentativeInvitation.label)

Source: http://mxr.mozilla.org/comm-central/search?string=data.button[123]&regexp=1&find=calItipUtils&filter=^[^\0]*%24&tree=comm-central

Comment 17

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 771830 [details] [diff] [review]
patch

r- to handle the other actions.

Comment 18

[Richard Marti (:Paenglab)]

Attachment: patch v2

Okay, this patch adds only to the Accept, Decline and Tentative buttons an icon through adding a action attribute. As I understand the code all other buttons are shown single and don't need a icon for better discoverability and I think icons aren't needed then. If you think I should add icons I can try this.

I haven't set the icon to the class itself like

.imip-button {
  list-style-image: url(chrome://lightning/skin/imip.png);
}

because then the icons are also to the buttons applied which have now no icon and then I have to add rules to hide the icon on them.

Comment 19

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 833457 [details] [diff] [review]
patch v2

Review of attachment 833457 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp

Comment 20

[Richard Marti (:Paenglab)]

c-c push: http://hg.mozilla.org/comm-central/rev/f12559416caf