Closed Bug 458572 Opened 13 years ago Closed 7 years ago

add icons to the imip-bar buttons

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: maxxmozilla, Assigned: Paenglab)

Details

(Whiteboard: [good first bug][mentor=Fallen][lang=css])

Attachments

(6 files, 1 obsolete file)

Add icons to the imip-bar buttons (accept, decline, tentative etc.).
Note that Dan pointed out it would be nice to move the imip bar to using a <notificationbar> in bug 372424. This could possibly make that step easier.

Otherwise its just a matter of adding some styles and maybe classes. We'd also need UI for this (and a decision if its really wanted)
Keywords: uiwanted
Whiteboard: [good first bug]
Whiteboard: [good first bug] → [good first bug][mentor=Fallen][lang=css]
Assignee: nobody → LenoirINT
Adding new contributor and pointing him to the mentor....
Status: NEW → ASSIGNED
Hi LenoirINT! I'm excited you've decided to tackle this bug and am glad to help out. First of all, we will need some icons:

* One icon per button, obviously
* There are certain platform differences so: different icon per platform
* Windows is split up in windows-aero and classic so this needs separate icons too

Its possible that we could re-use either our own icons or Thunderbird icons, this needs to be investigated. In case we do need new icons, how are you with icon design? I've CC'd some of the Thunderbird UI Folks that may be able to help out in case you're not so much into graphics design.
Attached image proposal
Quick hack to show how it could look.
Maybe the icons from calendar-invitations-dialog-button-images.png could be used to accept or decline. This would be consistent with the Attendee dialog. For the Tentative button i created a icon with the same color (rgb(21, 137, 255)) the Attendee dialog uses to show the tentative state.

For XP and Linux this could be done like this. Aero and OSX are now using monochrome icons. Should we also use monochrome icons for the IMIP bar for this systems? The screenshot is made on Win7 and shows how the mixture would look.
I think we should not mix icon styles.
Attached image IMIP icons for Aero
I created icons for Aero.
What do you think about them?
Attached image IMIP icons for OSX
And icons for OSX
I agree that the icon style should match the icon style that is used by Thunderbird in the message preview pane. Regarding the icon picture I'd use the 2nd proposal using check mark, "x" and "?". The "?" looks out of place / inverted compared to the other images because it is white on black compared to black on white. How would a black "?" without the background look on the buttons?
The first icon came from chat toolbar, but was a exclamation mark with the same withe.

I think this approach looks now better.
(In reply to Richard Marti [:paenglab] from comment #9)
> Created attachment 646211 [details]
> IMIP icons for Aero alternative
> 
> The first icon came from chat toolbar, but was a exclamation mark with the
> same withe.
> 
> I think this approach looks now better.

I like these icons above. I also do graphics but as this is my first bug I am having a hard enough time just dealing with the request to add these in. So thank you to those who are helping with the graphics and giving feedback.
Can you confirm that you're still working on this bug?
Flags: needinfo?(LenoirINT)
Flags: needinfo?(LenoirINT)
Attached patch patch (obsolete) — Splinter Review
Patch gives the imip buttons icons.

On Linux I tried to use GTK-icons but found no one for Tentative which fits well. Now I used the XP icons.
Assignee: LenoirINT → richard.marti
Attachment #771830 - Flags: ui-review?(philipp)
Attachment #771830 - Flags: review?(philipp)
Does this work out when the imip buttons have other actions? They can have different meanings depending on the imip action.
Flags: needinfo?(richard.marti)
The css differentiates only between imip-button1, imip-button2 and imip-button3. If this isn't enough I could try to add a class or something else.

What other actions could this three button-IDs have?
Flags: needinfo?(richard.marti)
Flags: needinfo?(philipp)
Button 1 can be:
  - Details…         (imipDetails.label)
  - Update           (imipUpdate.label)
  - Add To Calendar  (imipAddToCalendar.label)
  - Accept           (imipAcceptInvitation.label)
  - Cancel           (imipCancelInvitation.label)
  - Send             (imipSend.label)

Button 2 can be:
  - Decline          (imipDeclineInvitation.label)

Button 3 can be:
  - Tentative        (imipAcceptTentativeInvitation.label)

Source: http://mxr.mozilla.org/comm-central/search?string=data.button[123]&regexp=1&find=calItipUtils&filter=^[^\0]*%24&tree=comm-central
Flags: needinfo?(philipp)
Comment on attachment 771830 [details] [diff] [review]
patch

r- to handle the other actions.
Attachment #771830 - Flags: ui-review?(philipp)
Attachment #771830 - Flags: review?(philipp)
Attachment #771830 - Flags: review-
Attached patch patch v2Splinter Review
Okay, this patch adds only to the Accept, Decline and Tentative buttons an icon through adding a action attribute. As I understand the code all other buttons are shown single and don't need a icon for better discoverability and I think icons aren't needed then. If you think I should add icons I can try this.

I haven't set the icon to the class itself like

.imip-button {
  list-style-image: url(chrome://lightning/skin/imip.png);
}

because then the icons are also to the buttons applied which have now no icon and then I have to add rules to hide the icon on them.
Attachment #771830 - Attachment is obsolete: true
Attachment #833457 - Flags: ui-review?(philipp)
Attachment #833457 - Flags: review?(philipp)
Comment on attachment 833457 [details] [diff] [review]
patch v2

Review of attachment 833457 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp
Attachment #833457 - Flags: ui-review?(philipp)
Attachment #833457 - Flags: ui-review+
Attachment #833457 - Flags: review?(philipp)
Attachment #833457 - Flags: review+
c-c push: http://hg.mozilla.org/comm-central/rev/f12559416caf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.0
Flags: needinfo?(philipp)
Keywords: uiwanted
Attachment #771830 - Flags: ui-review?(philipp)
You need to log in before you can comment on or make changes to this bug.