458659 - Hang [@ nsColumnSetFrame::ReflowChildren] with -moz-column, height:0

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase (hangs Firefox when loaded)

Gary Kwong found this back in May, but at the time I thought it was the same as bug 429981.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Also on Windows.

Comment 2

[Mats Palmgren (inactive)]

We're creating new columns in an endless loop so I guess this crashes
if you leave it running long enough.

Comment 3

[Mats Palmgren (inactive)]

Attachment: wip

A bit wallpaper-ish perhaps but it fixes it, bailing the loop with
the warning "Too many zero height columns".

Comment 4

[Jesse Ruderman]

Will the second assertion be hit with something like
<div style="-moz-column-width: 10px; height: 1px;"><div style="height: 20000px;"></div></div>
?

Comment 5

[Mats Palmgren (inactive)]

Yes.

Comment 6

[Jesse Ruderman]

Then it probably shouldn't be an assertion :)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Having a maximum number of columns is a good idea.

But we shouldn't be creating an infinite number of empty columns, that's a bug we should fix. The real question is what the rendering of the testcase should be.

Comment 9

[Jesse Ruderman]

WFM. I wonder what fixed it.

Comment 10

[Jesse Ruderman]

Oh, it's just that bug 695222 changed the default column-fill default from "auto" to "balance".  If I modify the testcase to specify column-fill: auto, it hangs again.

Comment 11

[Jesse Ruderman]

Attachment: testcase (hangs Firefox when loaded)

Comment 12

[Scott Johnson (:jwir3)]

Seems to be fixed now.