Make use of new search textbox widget in Help

VERIFIED FIXED in mozilla1.9.1b2

Status

defect
VERIFIED FIXED
11 years ago
3 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
mozilla1.9.1b2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch One-linerSplinter Review
I got tired of the warning is the error console... Can we please do this?
Attachment #341953 - Flags: review?(gavin.sharp)
(in the error console)
You can remove timeout="500".
(In reply to comment #2)
> You can remove timeout="500".

Thanks - I'll do that when/if I push it
Attachment #341953 - Flags: review?(gavin.sharp) → review?(dao)
Comment on attachment 341953 [details] [diff] [review]
One-liner

Dao is a better reviewer for this, I'm not very familiar with the new search binding.
Attachment #341953 - Flags: review?(dao) → review+
Pushed changeset 15d37b3451cf.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> Pushed changeset 15d37b3451cf.

Without 'timeout="500"' (and everything on one line).
So, it appears that what I pushed was the original file without the timeout attribute. It would of course have been better if I had applied the patch.. This is now corrected in changeset 559223858f49.
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090202 SeaMonkey/2.0a3pre
Status: RESOLVED → VERIFIED
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.