458797 - Invites to queue and workgroups don't work

Status: RESOLVED FIXED

(support.mozilla.org Graveyard :: Chat, defect)

Description

[Matthew Middleton (:zzxc)]

All invites to Fastpath queues and workgroups aren't working when Fastpath is built with Java 1.6.  This version of Java was used to rebuild fastpath.jar to incorporate bug 450060.

Comment 1

[Matthew Middleton (:zzxc)]

This is fixed on the development server by reverting to Java 1.5.  It will be fixed on production when this is pushed to production.

Comment 2

[Laura Thomson :laura]

Need bug 464779 to be fixed before we can push to prod.

Comment 3

[Matthew Middleton (:zzxc)]

Fixed by upgrading to Openfire 3.6.2 with Java 1.5

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Matthew, do you have a handy testcase for this?  Thanks!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Matthew, do you have a handy testcase for this?  Thanks!

Would it be something like this, which still doesn't work?

https://chat-support.mozilla.com:9091/plugins/fastpath/workgroup-queue-agents.jsp?wgID=[e-mail]&qID=24513

Comment 6

[Matthew Middleton (:zzxc)]

The issue here is that inviting a workgroup (such as [e-mail]) doesn't work.  The invite request is dropped, and agents in the trainees workgroup never receive chat offers.  This is still broken on production, which uses RPM packages for Openfire, but it works on staging.  (Staging is currently built from source)

I need to debug this further, to be able to fix this and remove our dependence on Java 1.5.  Since it's still broken on production, I am reopening this bug and targeting for 0.9.  (This can be fixed either by moving to the Java 1.5 source build, or fixing the code that is resulting in this issue)

To test for this bug:

1) Start two Spark connections to Openfire with two users.  One user should be in the Support workgroup, the other in Trainees.  Both should be logged into Fastpath.

2) Start a new Live Chat session, and accept it with the Spark connection logged into Support.

3) Invite the trainees workgroup, using the invite button in the right pane of the Spark window.  "Trainees" is in the default roster, under the group "Admins".

4) If this bug is fixed, the user in Trainees should receive a Fastpath "toaster" popup containing a chat offer.  This chat offer should be the question that you just invited trainees to, and you will have 20 seconds to accept.

Comment 7

[Matthew Middleton (:zzxc)]

Attachment: Catch the exception for Java 1.5 (checked in)

The cause of this bug's regression on production with Java 1.5 is an uncaught exception in the patch for bug 450060.  Direct invitations aren't assigned to a queue, resulting in an uncaught NullPointerException.  I checked this in with r21251, so workgroup invitations again work in Java 1.5.

This fails elsewhere with Java 1.6, with the exception below.  This exception will need to be caught when we upgrade to Java 1.6.  For now, this bug is fixed (again).


java.lang.NullPointerException
	at org.jivesoftware.xmpp.workgroup.request.InvitationRequest.getUserJID(InvitationRequest.java:203)
	at org.jivesoftware.xmpp.workgroup.request.Request.sendOffer(Request.java:236)
	at org.jivesoftware.xmpp.workgroup.dispatcher.RoundRobinDispatcher.dispatch(RoundRobinDispatcher.java:170)
	at org.jivesoftware.xmpp.workgroup.dispatcher.RoundRobinDispatcher$2.run(RoundRobinDispatcher.java:112)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Is comment 2 still true?  Where can comment 6 be tested: prod or staging?