Developer replies to reviews no longer indented

VERIFIED FIXED in 4.0.2

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: Dave Garrett, Assigned: lorchard)

Tracking

({polish, regression})

unspecified
4.0.2
polish, regression

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 341990 [details]
sample screenshot

The developer replies to reviews used to be indented. They're not anymore and now they look like reviews and not replies at first glance. I don't remember when this changed.

Over in bug 435263, the new patch to allow multiple reviews will let the old reviews be shown below in an indented fashion, so the dev replies should also be indented to match.

Comment 1

10 years ago
This was fixed, according to "svn blame" in r19039 by lorchard. Here's an example that it's back: https://addons.mozilla.org/en-US/firefox/reviews/display/2464 .

Thanks for filing it: It's important that we don't lose these little UI details while implementing "bigger" features.
Assignee: nobody → lorchard
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: regression
Resolution: --- → FIXED
Target Milestone: --- → 4.0.2
Oh, nice; we got it before the push :-)

(I knew about the regression but wasn't aware of the fix myself, either; thanks, Fred!)

Verified
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.