458814 - Developer replies to reviews no longer indented

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Garrett]

Attachment: sample screenshot

The developer replies to reviews used to be indented. They're not anymore and now they look like reviews and not replies at first glance. I don't remember when this changed.

Over in bug 435263, the new patch to allow multiple reviews will let the old reviews be shown below in an indented fashion, so the dev replies should also be indented to match.

Comment 1

[Fred Wenzel [:wenzel]]

This was fixed, according to "svn blame" in r19039 by lorchard. Here's an example that it's back: https://addons.mozilla.org/en-US/firefox/reviews/display/2464 .

Thanks for filing it: It's important that we don't lose these little UI details while implementing "bigger" features.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Oh, nice; we got it before the push :-)

(I knew about the regression but wasn't aware of the fix myself, either; thanks, Fred!)

Verified