458897 - start-msvc*.bat fails to run bash when MozillaBuild install path contains a space or batch file special character

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: 

Now, last line of start-msvc*.bat is
%MOZILLABUILD%\msys\bin\bash --login -i
But, it doesn't call bash when %MOZILLABUILD% contains space of some special character of batch file.

For example, If MozuillaBuild is installed on "C:\Mozilla Build" and C:\Mozilla.bat exists,

%MOZILLABUILD%\msys\bin\bash --login -i

Will be evaluated as

C:\Mozilla Build\msys\bin\bash --login -i

So, It will run C:\Mozilla.bat



Reproducible: Always

Steps to Reproduce:
1.Install MozillaBuild to C:\Mozilla Build
2.Create C:\Mozilla.bat
3.run start-msvc*.bat
Actual Results:  
Mozilla.bat will executed

Expected Results:  
bash should be executed.

To fix this issue, last line of start-msvc*.bat should be
"%MOZILLABUILD%\msys\bin\bash" --login -i

Comment 1

[(not currently active) Ted Mielczarek]

Pushed a fix:
http://hg.mozilla.org/mozilla-build/rev/1d6462e9ee3a
will be in MozillaBuild 1.4.