458938 - get a compare-locales version for production machines to use

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

When we will want to have compare-locales for mozilla-central (since for 1.9.0 will not be blocking as per call with Axel) we should be able to find something figured out.

There is one version of compare-locales in:
http://hg.mozilla.org/users/axel_mozilla.com/tooling/file/tip/mozilla/testing/tests/l10n/

What there is in CVS has not had work on it since December 2007 and has fall behind from Axel's development
http://mxr.mozilla.org/mozilla/source/testing/tests/l10n/

As per conversation with Axel; Gandalf and Adrian are doing some more development on it

I want to use this bug as way of keeping the other two compare-locales related bugs in context

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

There is another compare-locales script, activly developed by Adrian right now.

He's merging Axel's compare-locales with Silme library. The good thing about it is that Silme does cover pretty nice list of features that you may want to extending compare-locales shouldn't be a problem.

All is down to what do you need.

http://hg.mozilla.org/users/akalla_aviary.pl/silme-patched/file/0207a01d1b99/scripts/compare-locales2.py

Comment 2

[Axel Hecht [:Pike]]

We shouldn't bother the rel-eng team with the silme version until it's ready for production.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Pike: roger that

Comment 4

[Axel Hecht [:Pike]]

http://hg.mozilla.org/users/axel_mozilla.com/tooling/file/a850a69c5b7a/compare-locales/ is the version to use.

You'll need http://hg.mozilla.org/users/axel_mozilla.com/tooling/file/a850a69c5b7a/compare-locales/scripts/compare-locales, with adjusted shebang, and http://hg.mozilla.org/users/axel_mozilla.com/tooling/file/a850a69c5b7a/compare-locales/lib/ should be in PYTHONPATH.

Comment 5

[Axel Hecht [:Pike]]

updating revision to http://hg.mozilla.org/users/axel_mozilla.com/tooling/file/487d597612fd/compare-locales/

l10n-merge doesn't work for defines files, so I had to disable that. Discovered that while working on bug 461979.

Comment 6

[Seth Bindernagel]

What does moving this status to RelEng: Future mean?  It seems to be very important for the l10n community to have a working version of compare-locales in the build process.  Not sure when "future" means, but I would like to have this back to a closer time frame.  Can someone provide clarity?  How long is "future"?

If it seems helpful, I am happy to arrange a discussion about why compare-locales is important to all the localization teams?

Comment 7

[Armen [:armenzg]]

Seth, currently compare-locales is being run on the l10n-dashboard which localizers look at and they will still be able to look at that output over there.

Currently there is not a maintained compare-locales in our repos and the newer python version that is maintained, it currently lives in pike's repo.
To run code that has not been reviewed in the release machines could lead us to unknown problems during a release.
You can also check this bug 458938 for more info

Comment 8

[Chris Cooper [:coop] (he/him)]

Axel: is the revision in comment #5 still the most up-to-date? I'd like to start reviewing.

Comment 9

[Axel Hecht [:Pike]]

Yes, compare-locales 0.6.1 of comment 5 is still current.

There is a slight nit in http://hg.mozilla.org/users/axel_mozilla.com/tooling/rev/b2fc94a2af23, which fixes a bug for the l10n builds setup.

tip is essentially just as good right now for you, too. The differences are only affecting the other sub parts.

Comment 10

[Chris Cooper [:coop] (he/him)]

I've merged Axel's compare-locales into http://hg.mozilla.org/build/tools. I removed the web/ subdir since Axel tells me that's no longer used. I'll want to add some comments to the compare-locales libs (class descriptions and such) but those become commits regardless of which repo we're dealing with.

Axel: can you start working from this new repo, assuming I didn't miss anything? It was a trivial merge, so I don't expect any issues.

We'll use the current tip (changeset: 225:db705930f780) for build steps until Axel's tells us a new changeset is ready for testing. 

Note that this code is not yet being used in build steps. I'll file a new bug shortly to hook this code up to Armen's repack-on-change work (bug 464163).

Comment 11

[Chris Cooper [:coop] (he/him)]

compare-locales has been moved to its own repo to facilitate development independent of the other build tools:

http://hg.mozilla.org/build/compare-locales/

Sorry for polluting the build/tools repo with bogus history. :/

Comment 12

[Axel Hecht [:Pike]]

http://hg.mozilla.org/users/axel_mozilla.com/tooling/rev/d1c2d7d0afdc is the corresponding landing in my tooling repo, build/compare-locales it is from now on.