458946 - reduce narrow windows API calls in cairo win32 surface

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

There is a call to FormateMessageA and LoadLibraryA which are unnessesary and can be replaced with their wide char equivalents.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: switches to FormatMessageW and LoadLibraryW

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 342138 [details] [diff] [review]
switches to FormatMessageW and LoadLibraryW

Looks fine, I'll drop this in to cairo upstream as well.  (No need for a patch in gfx/cairo for this, as I'm doing it right away.)

Comment 4

[Doug Turner (:dougt)]

143e49ad9482	blassey — Bug 458946 - Reduce narrow windows API calls in cairo win32 surface. r=vlad


vlad -- i did not create a patch in gfx/cairo per your instructions.

Comment 6

[Aiko]

Comment on attachment 342138 [details] [diff] [review]
switches to FormatMessageW and LoadLibraryW

>+	fwprintf (stderr, "%S: %s", context, (char *)lpMsgBuf);

Should be L"%S: %s":

e:/builds/moz2_slave/mozilla-central-win32-nightly/build/gfx/cairo/cairo/src/cairo-win32-surface.c(99) : warning C4133: 'function' : incompatible types - from 'char [7]' to 'const wchar_t *'

Also, casting lpMsgBuf, which now points to an WCHAR array to a char * may work but it's still nasty.

Comment 7

[Aiko]

Attachment: actually working patch

Strange how nobody has noticed that GDI errors are silently discarded or the compiler warnings.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 360698 [details] [diff] [review]
actually working patch

This looks fine (we don't really hit this path); but please make sure to get a patch added to gfx/cairo and a mention in the README; otherwise this will get wiped out on the next cairo update.

Comment 9

[Aiko]

Attachment: with patch-in-patch

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

vlad, review ping?

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 360898 [details] [diff] [review]
with patch-in-patch

bouncing over to jeff for integration into cairo

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 360898 [details] [diff] [review]
with patch-in-patch

This has already been fixed and merged from upstream.