Start page urls are incorrect (missing '&')

RESOLVED FIXED

Status

Thunderbird
Preferences
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: gozer, Assigned: gozer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 342134 [details] [diff] [review]
add missing '&' to urls

Specifically, these 3:

mailnews.start_page.welcome_url
mailnews.start_page.url
mailnews.start_page.override_url

All have the same typo:

?locale=%LOCALE%version=%VERSION%[...]
 instead of
?locale=%LOCALE%&version=%VERSION%
Attachment #342134 - Flags: review?(bugzilla)
Comment on attachment 342134 [details] [diff] [review]
add missing '&' to urls

We also need the same change in other-licenses/branding/thunderbird
Attachment #342134 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 2

9 years ago
Created attachment 342190 [details] [diff] [review]
add missing '&' to urls v2

Not sure why my grep didn't catch it, but here is a revised patch that includes both files.
Assignee: nobody → gozer
Attachment #342134 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #342190 - Flags: review?(bugzilla)
Comment on attachment 342190 [details] [diff] [review]
add missing '&' to urls v2

..%LOCALE%version%version=%VERSION%...

Not sure that's quite right ;-)
Attachment #342190 - Flags: review?(bugzilla) → review-
(Assignee)

Comment 4

9 years ago
Created attachment 342435 [details] [diff] [review]
add missing '&' to urls v3

Correct for idiotic vim search-and-replace.
Attachment #342190 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Attachment #342435 - Flags: review?(bugzilla)
Attachment #342435 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 5

9 years ago
Comment on attachment 342435 [details] [diff] [review]
add missing '&' to urls v3

changeset:   574:da42f7f36f7b
tag:         tip
user:        Philippe M. Chiasson <gozer@mozillamessaging.com>
date:        Fri Oct 10 12:23:31 2008 -0400
summary:     Bug 458949. Fix start pages urls missing an '&'. r=Standard8
Attachment #342435 - Attachment filename: thunderbird-branding.js.diff → [checked in] thunderbird-branding.js.diff
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.