458953 - undef'ing LoadImage in nsSVGFilters.cpp breaks wince build

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: excludes WINCE from undef

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+#ifndef WINCE
 #undef LoadImage
+#endif

Wouldn't it make more sense for this to be #ifdef LoadImage?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

that was my first thought.  It turns out that LoadImage exists on windows ce.  The problem is when the class calls its own version of LoadImage, it fails.  Blame bad compilers if you must...its a hack either way.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't get it. Does

#ifdef LoadImage
#undef LoadImage
#endif

fail to build on WinCE? What exactly does the error say?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

c:/hg/mozilla-central/content/svg/content/src/nsSVGFilters.cpp(5314) : error C3861: 'LoadImage': identifier not found

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What if you qualify LoadImage with "nsImageLoadingContent::"?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

with #if defined(XP_WIN) 
// Prevent Windows redefining LoadImage
#ifdef LoadImage
#undef LoadImage
#endif
#endif

and 

nsImageLoadingContent::LoadImage

I get:

c:/hg/mozilla-central/content/svg/content/src/nsSVGFilters.cpp(5314) : error C2039: 'LoadImage' : is not a member of 'nsImageLoadingContent'

with 

with #if defined(XP_WIN) 
// Prevent Windows redefining LoadImage
#ifndef WINCE
#undef LoadImage
#endif
#endif

and nsImageLoadingContent::LoadImage it compiles

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 342140 [details] [diff] [review]
excludes WINCE from undef

OK, but that compiler is really broken.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

we know...

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

2e73030a8bec: Bug 458953 - undef'ing LoadImage in nsSVGFilters.cpp breaks wince build r=roc
diff
browse
Brad Lassey <[e-mail]> - Thu, 16 Oct 2008 10:53:36 -0400 - rev 20537
Bug 458953 - undef'ing LoadImage in nsSVGFilters.cpp breaks wince build r=roc