Status

()

defect
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

Tracking

Trunk
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

11 years ago
Posted patch nukingSplinter Review
Attachment #342160 - Flags: review?(mrbkap)
Attachment #342160 - Flags: superreview+
Attachment #342160 - Flags: review?(mrbkap)
Attachment #342160 - Flags: review+
(Assignee)

Comment 1

11 years ago
here is a more exciting patch! Missed this unused member last time as I was fixing some false positives in my detector and was rerunning the analysis, so didn't have most recent data.
Assignee: nobody → tglek
Status: NEW → ASSIGNED
Attachment #342270 - Flags: review?(mrbkap)
Comment on attachment 342270 [details] [diff] [review]
found an unused member

I bow to your regexp-fu! :)
Attachment #342270 - Flags: superreview+
Attachment #342270 - Flags: review?(mrbkap)
Attachment #342270 - Flags: review+
(Assignee)

Comment 3

11 years ago
sorry for patch bombing, caveman algorithm causes long turnarounds so i miss these things initially.
Attachment #342330 - Flags: review?(mrbkap)
Comment on attachment 342330 [details] [diff] [review]
another unused member that surfaces after analysing with patch 1

Keep patch bombing me. I'm glad to see this stuff go!
Attachment #342330 - Flags: superreview+
Attachment #342330 - Flags: review?(mrbkap)
Attachment #342330 - Flags: review+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 6

11 years ago
confused, you left dead code afaict:

http://mxr.mozilla.org/comm-central/search?string=ContainFunc
    * line 99 -- typedef PRBool (*ContainFunc)(eHTMLTags aTag,nsDTDContext &aContext);

Found one matching line

please do try to kill typedefs when you whack all consumers :)
(Assignee)

Comment 7

11 years ago
Posted patch missed stuffSplinter Review
timeless is right, I didn't get everything. I don't yet scan for dead typedefs(it's hardly worth the hassle afaik).
Attachment #342957 - Flags: review?(mrbkap)
(Assignee)

Updated

11 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #342957 - Flags: superreview+
Attachment #342957 - Flags: review?(mrbkap)
Attachment #342957 - Flags: review+
(Assignee)

Comment 8

11 years ago
pushed http://hg.mozilla.org/mozilla-central/rev/e0d2eba61212
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.