458983 - dead stuff in nsHTMLElement

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[(dormant account)]

Attachment: nuking

Comment 1

[(dormant account)]

Attachment: found an unused member

here is a more exciting patch! Missed this unused member last time as I was fixing some false positives in my detector and was rerunning the analysis, so didn't have most recent data.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 342270 [details] [diff] [review]
found an unused member

I bow to your regexp-fu! :)

Comment 3

[(dormant account)]

Attachment: another unused member that surfaces after analysing with patch 1

sorry for patch bombing, caveman algorithm causes long turnarounds so i miss these things initially.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 342330 [details] [diff] [review]
another unused member that surfaces after analysing with patch 1

Keep patch bombing me. I'm glad to see this stuff go!

Comment 5

[(dormant account)]

pushed http://hg.mozilla.org/mozilla-central/rev/8ba4bc3e2d8b

Comment 6

[timeless]

confused, you left dead code afaict:

http://mxr.mozilla.org/comm-central/search?string=ContainFunc
    * line 99 -- typedef PRBool (*ContainFunc)(eHTMLTags aTag,nsDTDContext &aContext);

Found one matching line

please do try to kill typedefs when you whack all consumers :)

Comment 7

[(dormant account)]

Attachment: missed stuff

timeless is right, I didn't get everything. I don't yet scan for dead typedefs(it's hardly worth the hassle afaik).

Comment 8

[(dormant account)]

pushed http://hg.mozilla.org/mozilla-central/rev/e0d2eba61212