Closed
Bug 459038
Opened 16 years ago
Closed 16 years ago
linux -memstats privates bytes shows 0K
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dschaffe, Assigned: tierney)
Details
Attachments
(1 file)
2.77 KB,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
on linux for all tests private bytes always shows 0k, other fields seems possibly incorrect. The correct messages memstats output appears but private bytes is 0. e.g. avmshell -memstats test/performance/scimark/FFT.abc ... [mem] ------- gross stats -------- [mem] private 0 (0K) 0% [mem] mmgc 28064 (109.6M) 0% [mem] unmanaged 14 (56K) 0% [mem] managed 221 (884K) 0% [mem] free 26344 (102.9M) 0% [mem] jit 0 (0K) 0% [mem] other 1020512 (3986.4M) 0% [mem] bytes (internal fragmentation) 185 (743K) 79% [mem] managed bytes 178 (715K) 80% [mem] unmanaged bytes 7 (28K) 50% [mem] -------- gross bytes -------
Flags: wanted-flashplayer10+
Flags: in-testsuite+
Flags: flashplayer-triage+
Reporter | ||
Updated•16 years ago
|
Flags: flashplayer-qrb?
Comment 1•16 years ago
|
||
we need to parse the private bytes out of /proc/<pid>/ something or other...
Assignee | ||
Comment 2•16 years ago
|
||
Implements GetPrivateBytes for linux. It parses the data out of /proc/$pid/smaps which contains a bunch of info about memory for the process. Also added code to touch each page returned from GCHeap::CommitMemory - this was neccessary so that private bytes contained all the allocated memory, as in https://bugzilla.mozilla.org/show_bug.cgi?id=459042. However, this is only the linux fix.
Attachment #343291 -
Flags: review?(treilly)
Comment 3•16 years ago
|
||
Comment on attachment 343291 [details] [diff] [review] Implement GetPrivateBytes for linux looks good, probably need an ifdef LINUX here since this filed if this file is used by other unices.
Attachment #343291 -
Flags: review?(treilly) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Added ifdef LINUX. Pushed to tamarin-redux: http://hg.mozilla.org/tamarin-redux/rev/526961e72aea
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•16 years ago
|
||
Memory is being tracked via performance runs and is being logged. Also manually verified reproducible steps from comment #0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•