459041 - jar: URLs break sss_serializeSessionStorage (and thus SessionStore)

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Comment 1

[Simon Bünzli]

Attachment: fix

So instead of clearing out the path (which can throw even for nsIURLs), let's use the prePath instead (which is what we want, anyway), resp. the full URI when the prePath would be trivial/host-less.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 342242 [details] [diff] [review]
fix

r=me, thanks. is this covered by the existing storage test?

Comment 3

[Simon Bünzli]

(In reply to comment #2)
> is this covered by the existing storage test?

Minimally; the test isn't very extensive in itself, I'd rather wait for bug 455070 until extending it to include several domains and edge cases (including failures).

Comment 4

[(no longer active)]

This patch has bitrotted, we need a new patch here.

Comment 5

[Simon Bünzli]

Attachment: for check-in

Besides unbitrotting, this harmonizes the try-catch-block from bug 458954 with the one added here and drops one |continue| to slightly clear up the code flow.

Comment 6

[(no longer active)]

Pushed to mozilla-central: <http://hg.mozilla.org/mozilla-central/rev/ef4464dc1bd7>