Closed
Bug 459091
Opened 16 years ago
Closed 16 years ago
allow basic mac sample plugin to build unmodified in our tree
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file)
|
2.38 KB,
patch
|
dougt
:
superreview+
|
Details | Diff | Splinter Review |
We can now allow our mac basic sample plugin to build unmodified in our tree.
Attachment #342286 -
Flags: superreview?(jst)
Attachment #342286 -
Flags: superreview?(jst) → superreview?(doug.turner)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 342286 [details] [diff] [review]
fix v1.0
worked for me.
I do not like having fixed paths like that. Is there a way.
extra points: don't you want to also modify the Makefile in plugin/sdk/samples so that it built?
Attachment #342286 -
Flags: superreview?(doug.turner) → superreview+
|
|
||
Comment 2•16 years ago
|
||
is there a way to not do that?
That plugin isn't really made to be integrated with our tree in particular, there is no makefile setup for doing so and we don't use it for anything. The idea is that SDK plugins can be built against anything, including WebKit. I just figured instead of having a stand-in include "npapi.h" we might as well make it something that happens to make it work in our tree.
landed on trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•