459150 - avoid non-pixel-aligned clips for mobile's DrawWindow usage

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: snap to pixels more aggressively

Non-pixel-aligned clips hurt a lot, so avoid them as much as possible.  Mobile currently sets a native cairo scale before calling DrawWindow, so even though gecko code tries to keep everything pixel-aligned, it fails in this case due to a CTM with scale.  This patch adds a few tweaks in #ifdef MOZ_GFX_MOBILE_OPTIMIZE and explicitly tells Rectangle() to snap coordinates and ignore scale (by default it only snaps if there's just a translation and not a scale).  Some of these may be good in general, but for now keep them behind that #ifdef until we can figure out what weird interactions there might be with this.

(As a bonus, we can avoid a temporary surface inside DrawWindow here in a common case.)

Comment 1

[Stuart Parmenter]

Attachment: add your thing to configure

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 342359 [details] [diff] [review]
add your thing to configure

That's fine, I'll roll it in to my patch when I check in.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked this in; it's causing some rounding problems with drawWindow, noticable as slight shifts when the display is repainted, but it's not horrible.  I think this is the rect rounding that's happening directly in the drawWindow call.  We can probably resolve this in fennec directly by being smarter about picking coordinates to start the draw on...