459165 - Use the contextCallback in XPConnect

Status: RESOLVED DUPLICATE of bug 408539

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

XPConnect tries to keep a list of XPCContexts in sync with their corresponding JSContexts. Currently, it doesn't use the contextCreated callback and has to rely on noticing a JSContext without an associated XPCContext. Because there is no contextDestroyed callback, we occasionally run some code to reap "stale" XPCContexts. This can be expensive with lots of contexts and provides a gap where we might try to use a dead JSContext through its XPCContext.

Providing a contextDestroyed callback would solve this.

Comment 1

[Brendan Eich [:brendan]]

JS_PUBLIC_API(JSContextCallback)
JS_SetContextCallback(JSRuntime *rt, JSContextCallback cxCallback)

has been there for a while.

/be

Comment 2

[Igor Bukanov]

See also bug 408539 - I think this bug is a dup of that, isn't it?

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Wow. I'm clearly batting 0 for 2 here. This is a dupe of bug 408539. On the other hand, I think we want to backport the fix for this bug to stable branches (I filed this in response to a topcrasher pointed out by Ben Turner) and that patch is rather big to do so.