45919 - x-remote doesn't recognize ,noraise

Status: VERIFIED FIXED

(Core Graveyard :: X-remote, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I know just about nothing about X-Remote, so please forgive any misunderstanding
of what's supposed to work

DESCRIPTION:  When I use 'gnome-moz-remote' (a little program that rpm
identifies as from gnome-libs-1.0.53-1) while Mozilla is running, Mozilla
responds, but the URLs show up in mozilla with additional information after them.

Command:
gnome-moz-remote --raise http://www.mozilla.org/
Opens:
http://www.mozilla.org/

Command (my default URL handler in my GNOME config):
gnome-moz-remote --newwin http://www.mozilla.org/
Opens:
http://www.mozilla.org/,new-window,%20noraise

Command:
gnome-moz-remote http://www.mozilla.org/
Opens:
http://www.mozilla.org/,%20noraise

STEPS TO REPRODUCE:
 * start mozilla
 * enter one of the above commands

ACTUAL RESULTS:
 * urls open with stuff appended to them (except the first test above)

EXPECTED RESULTS:
 * the URL loaded is http://www.mozilla.org/ .  Handling the options would be
nice, but that's not quite as important.

DOES NOT WORK CORRECTLY ON:
 * Linux, mozilla, 2000-07-19 (my build)

WORKS CORRECTLY ON:
 * Linux NN 4.7x

Comment 1

[Christopher Blizzard (:blizzard)]

updating summary to accurate description and accepting.

Comment 2

[Christopher Blizzard (:blizzard)]

Attachment: workaround patch

Comment 3

[Jeffrey Baker]

I prefer my patch, which strips the noraise argument off of every command, not
just openURL, and also toggles a PR_BOOL raiseWindow.  Patch attached.

Comment 4

[Jeffrey Baker]

Attachment: Less hackish patch

Comment 5

[Jeffrey Baker]

Attachment: Patch to respect the noraise argument

Comment 6

[Jeffrey Baker]

The last patch adds support for the "noraise" argument of the remote protocol.
It has is effective for openUrl and openFile.  Why we have to different
functions for these two things is another question....

Waiting for review.

Comment 7

[Christopher Blizzard (:blizzard)]

looks fine to me r=blizzard

Comment 8

[Jeffrey Baker]

Blizzard, would you please check this in for me?  Approval from bendan, review
from you, but I don't have CVS access.

Comment 9

[Christopher Blizzard (:blizzard)]

will do.

Comment 10

[Jeffrey Baker]

I'd love to see this get in before we branch for M18, which I suspect is coming
up RSN.

Comment 11

[Christopher Blizzard (:blizzard)]

Checked in.

Comment 12

[Jeffrey Baker]

Tested and working in 2000-09-06-08 build on Linux.

Comment 13

[sairuh (rarely reading bugmail)]

rs vrfy based on jeffrey's comment.