Wizard back and next / finish buttons have incorrect space between them

RESOLVED FIXED in mozilla1.9.1b2

Status

()

Toolkit
Themes
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla1.9.1b2
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

See attached screenshots
Created attachment 342415 [details]
screenshots
Created attachment 342416 [details] [diff] [review]
patch
Assignee: nobody → robert.bugzilla
Attachment #342416 - Flags: review?(dtownsend)

Comment 3

9 years ago
Isn't that 1px too little between Back and Forward buttons?
(In reply to comment #3)
> Isn't that 1px too little between Back and Forward buttons?
I thought the same and just went with the exiting values. There are also other tweaks that should be done as can be seen when comparing it to the windows provided wizard and I would prefer them to be done in another bug.
Filed Bug 459280 for the inconsistencies I've noticed while working with the wizard.
Comment on attachment 342416 [details] [diff] [review]
patch

>diff --git a/toolkit/themes/winstripe/global/wizard.css b/toolkit/themes/winstripe/global/wizard.css
>--- a/toolkit/themes/winstripe/global/wizard.css
>+++ b/toolkit/themes/winstripe/global/wizard.css
>@@ -35,16 +35,16 @@ 
>...
>-.wizard-button[wizardbutton="finish"],
>-.wizard-button[wizardbutton="next"] {
>+.wizard-button[dlgtype="finish"],
>+.wizard-button[dlgtype="next"] {
>   -moz-margin-start: -1px !important;
> }
Dave, I went ahead a visually verified that this should be 0px to be consistent and I'll change that prior to checkin. The remainder of the issues that I've noticed will be handled in bug 459280
Comment on attachment 342416 [details] [diff] [review]
patch

Looks fine, sorry for not getting to it sooner
Attachment #342416 - Flags: review?(dtownsend) → review+
Pushed to mozilla-central with the change mentioned in comment #6

http://hg.mozilla.org/mozilla-central/rev/beb27b78ba0b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.