Closed
Bug 459266
Opened 16 years ago
Closed 16 years ago
TM: Allow CALLINFO macros to specify linkage
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
81.59 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
builtins.tbl:83: warning: ‘JSBool js_CloseIterator(JSContext*, jsval)’:
visibility attribute ignored because it
jsiter.h:76: warning: conflicts with previous declaration here
The one in jsiter.h is declared JS_FRIEND_API; the autogenerated one in builtins.tbl has no linkage qualifier; it is implicitly extern.
Most of the builtins should actually be static.
|
Assignee | |
Comment 1•16 years ago
|
||
v1 This patch changes the names of CallInfo objects. For example, ci_ToLowerCase -> js_ToLowerCase_ci js_ prefix: it's extern ci_fmod -> fmod_ci no js_ prefix: it's static
Assignee: general → jorendorff
Attachment #343321 -
Flags: review?(brendan)
|
||
Updated•16 years ago
|
Attachment #343321 -
Flags: review?(brendan) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 343321 [details] [diff] [review] v1 r=me, looks good. /be
|
|
Assignee | |
Comment 3•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/de77c05a49f8
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•