Closed
Bug 459294
Opened 16 years ago
Closed 16 years ago
TM: move soft float builtins next to SoftFloatFilter
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Unassigned)
Details
Attachments
(1 file)
|
5.86 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
...and under #ifdef NJ_SOFTFLOAT. But really just to get related stuff together. NJ_SOFTFLOAT isn't defined on the platforms I use, so I manually #defined it in Nativei386.h, and everything built. (I also had to add an #ifndef NJ_SOFTFLOAT around Assembler::fcmp in Nativei386.cpp to match the one in Assembler.h.)
Attachment #342496 -
Flags: review?(gal)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 342496 [details] [diff] [review] v1 Looks good. We should be able to test on x86 with SOFTFLOAT enabled (in theory).
Attachment #342496 -
Flags: review?(gal) → review+
|
Reporter | |
Comment 2•16 years ago
|
||
Alas, we can't; it doesn't work quite right. Pushed http://hg.mozilla.org/tracemonkey/rev/0884d01930b1
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•