459299 - nsNavHistory::SetPageTitleInternal is slow

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Shawn Wilsher :sdwilsh]

In fact, in shark profiles, 66% of the time is spent creating the statement that we use on a lot of page loads.  Ewww...

Comment 1

[Shawn Wilsher :sdwilsh]

It also makes a transaction, for no reason...

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 3

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

forgot to qrefresh to fix a unit test breaking change...

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 342516 [details] [diff] [review]
v1.1

>+  mozStorageStatementScoper scoper(mDBSetPlaceTitle);
>   // title
>   if (aTitle.IsVoid())
>-    dbModStatement->BindNullParameter(0);
>-  else
>-    dbModStatement->BindStringParameter(0, StringHead(aTitle, HISTORY_TITLE_LENGTH_MAX));
>+    mDBSetPlaceTitle->BindNullParameter(0);
>+  else
>+    mDBSetPlaceTitle->BindStringParameter(0, StringHead(aTitle, HISTORY_TITLE_LENGTH_MAX));
>   NS_ENSURE_SUCCESS(rv, rv);

need to get rv to check against first

r=me otherwise

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.2

Addresses review comments

Comment 6

[Shawn Wilsher :sdwilsh]

Apparently I already resolved this..

http://hg.mozilla.org/mozilla-central/rev/e04a9b7f832b