459300 - JSON should use internal JS functions where it makes sense

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Sayre]

Attachment: switch to js_* functions

Comment 1

[Robert Sayre]

I skipped a few that have macros as their body, will use the macros later if Shark shows call costs hurting.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 342503 [details] [diff] [review]
switch to js_* functions

>diff --git a/js/src/json.cpp b/js/src/json.cpp
>--- a/js/src/json.cpp
>+++ b/js/src/json.cpp
>@@ -98,17 +98,17 @@ struct StringifyClosure
>     jsval *s;
> };
> 
> static
> JSBool WriteCallback(const jschar *buf, uint32 len, void *data)

Nit, pre-existing: return type goes on same line as visibility/storage-class and other stuff including declarator mode.

Looks good otherwise, thanks.

/be