459417 - Wrong Partial update dialog text when no partial mars available

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1) Gecko/20081007 Firefox/3.1b1
Build Identifier: 

When updating from 3.1alpha 2 -> 3.1beta1, only a full update is offered.  However, if you attempt to force a update failure, it should not pop up a message saying a partial update is not available when in fact it was trying to update a complete update in the first place.   

See screenshot

Reproducible: Always

Steps to Reproduce:
1. Install 3.1alpha 2 build
2. set channelprefs.js = "betatest"
3. fire up alpha2, and check for updates
4. Download the update, notice its a complete update
5. When it asks for restart, click "Not now", and close firefox manually.
6. go to the Updates folder, and set the "pending" update.status to "failed"  (minus the quotes)
7. restart alpha 2, and open the secondary popup window
8. Verify the popup window shows text saying "The partial update could not be applied". 

Actual Results:  
There was never a "partial" update to begin with.  so this text in the dialog is wrong

Expected Results:  
It should have said "complete" instead, since that was what we were trying to update.

Comment 1

[Tony Chung [:tchung]]

Attachment: no partial update dialog screenshot

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

The update information isn't helping the client here, eg
  https://aus2.mozilla.org/update/1/Firefox/3.1a2/20080829082037/WINNT_x86-msvc/en-US/betatest/update.xml
So there's a partial and complete update declared, with identical file information. We may be able to give just the complete update but have done it this way for ever. I think there used to be a bug in the app that required both types to be given, not sure if that still exists. And there may be a restriction in the tool we use to generate the update snippets (which requires both types to be declared.)

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: screenshot when only a major is offered

I'm very sure Nick is correct in that the update xml file should only have the one entry for a complete update. When I perform the same steps using the same xml without the partial I get the ui in the attached screenshot and the only way I know of where a complete ends up in the failed state is when there are files in use which the updater will display the error and is bug 340535. App update will then try again on startup as shown in the attached screenshot.

I don't think there is anything to do on the client side for this bug and I am very sure the server side should be offering only the complete.

Comment 4

[Robert Strong (they/them - no direct email)]

I just verified that app update did download the partial as it should and therefore it showed the correct error. To simulate what you are trying to simulate you must also modify active-update.xml and updates.xml. Specifically you need to swap between the partial and complete patches the following

selected="undefined" state="undefined"

selected="true" state="pending" progress="100" status="9.8 of 9.8 MB" (this last one will be different per OS and 

and I believe you also should change isCompleteUpdate so its value is true

Then I get the correct error.