459490 - Console error when checking for Sunbird or Thunderbird software updates "Exception 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIDocShellHistory.useGlobalHistory] in browser.xml"

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect, P3)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081011 Calendar/1.0pre (BuildID: 20081011023826)

Steps to Reproduce:
  1. Start Sunbird with clean profile
  2. Open menu Help -> Check for Updates...
  3. Check Tools -> Error Console

Actual Results:

Update dialog shows normal behavior and reports that no updates where found. But Error Console reports:

Error: [Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIDocShellHistory.useGlobalHistory]"  nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)"  location: "JS frame :: chrome://global/content/bindings/browser.xml ::  :: line 643"  data: no]
Source File: chrome://global/content/bindings/browser.xml
Line: 647

Expected Results:
  No error.

Comment 1

[IU]

This bug also occurs with Shredder--even in safe mode

I'm not sure what product would be the best assignment; thus, I may have to open a separate bug for Shredder and let the devs figure it out.

Comment 2

[Daniel Boelzle [:dbo]]

IMO indicates there's a serious problem; should be on radar for 1.0.

Comment 3

[Robert Strong (they/them - no direct email)]

There is a xul:browser in the software update ui that is displayed for Major Updates billboard page and License page. If this error didn't happen previously then it sounds like something changed in xul:browser. If not then it sounds like Sunbird is missing something in its build.

Comment 4

[Robert Strong (they/them - no direct email)]

or error reporting changed (which it has recently) so this is now reported.

bent: could your work on error reporting caused this to now report to the error console?

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch - rev1

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 359073 [details] [diff] [review]
patch - rev1

Seems sensible we should have the history disabled here anyway, regardless of whether it fixes the error or not

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 359073 [details] [diff] [review]
patch - rev1

Drivers, I'd like to get this in while we are still doing the major update test... simple / safe fix where we disable history for the widget used by the update billboard and license.

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I doubt this is an error reporting difference... I seem to remember similar
issues (and a similar fix) at songbird.

Comment 9

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c969af636d82

Comment 10

[IU]

Is this really fixed?  I still get the error:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090130 Lightning/1.0pre

Comment 11

[Robert Strong (they/them - no direct email)]

This is fixed on trunk and after it bakes for another day it will likely get approved for 1.9.1 which is what you are running.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359073 [details] [diff] [review]
patch - rev1

a191=beltzner

Comment 13

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/00c9f0eacc58

Comment 14

[Stefan Sitter [:ssitter]]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090214 Calendar/1.0pre.

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090214 Lightning/1.0pre Shredder/3.0b2pre.