Closed
Bug 459537
Opened 17 years ago
Closed 17 years ago
TM: Stack water level is off by +1 in getTop
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
References
Details
Attachments
(1 file)
|
2.02 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
getTop() should return sp, but it return sp+1. However, fixing this exposes a bug in JSOP_CALLPROP where the tracker is update early (stack(0)) and afterwards we take a snapshot. If that snapshot fails the wrong value is written back.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #342753 -
Flags: review?(danderson)
|
|
||
Updated•17 years ago
|
Attachment #342753 -
Flags: review?(danderson) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
|
|
Assignee | |
Comment 3•17 years ago
|
||
This patch fixes the redundant comparisons at the end of loops that vlad pointed out a while ago. This might also explain some performance regressions in NJ2 since the underlying comparison code changed.
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•