Closed Bug 459537 Opened 12 years ago Closed 12 years ago

TM: Stack water level is off by +1 in getTop

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

Attachments

(1 file)

getTop() should return sp, but it return sp+1. However, fixing this exposes a bug in JSOP_CALLPROP where the tracker is update early (stack(0)) and afterwards we take a snapshot. If that snapshot fails the wrong value is written back.
Attached patch patchSplinter Review
Attachment #342753 - Flags: review?(danderson)
Attachment #342753 - Flags: review?(danderson) → review+
This patch fixes the redundant comparisons at the end of loops that vlad pointed out a while ago. This might also explain some performance regressions in NJ2 since the underlying comparison code changed.
Blocks: 457786
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
Depends on: 459630
You need to log in before you can comment on or make changes to this bug.