Closed Bug 459619 Opened 11 years ago Closed 11 years ago

Add zoom support to reftest harness

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
My patch supports a reftest-zoom attribute on the root element.
Attachment #342829 - Flags: superreview?(dbaron)
Attachment #342829 - Flags: review?(dbaron)
Shouldn't SetupZoom set fullZoom to 1.0 when there's no reftest-zoom attribute?  If not, why not?

Maybe your reftest-sanity test should also compare a div with:
  width: auto; margin: 10px; height: 10px;
to a div with:
  width: auto; margin: 15px; height: 15px;
?
The default is 1.0. We reset the zoom to 1.0 after taking the snapshot, so there shouldn't be any need to set it to 1.0 again for the next test.

Yes, adding that to the reftest-sanity test makes sense.
Ah... maybe put that assignment to 1.0 in a function called resetZoom() or unsetZoom() just so the symmetry is clear?
Attached patch fix v2Splinter Review
Attachment #342829 - Attachment is obsolete: true
Attachment #343129 - Flags: superreview?(dbaron)
Attachment #343129 - Flags: review?(dbaron)
Attachment #342829 - Flags: superreview?(dbaron)
Attachment #342829 - Flags: review?(dbaron)
Attachment #343129 - Flags: superreview?(dbaron)
Attachment #343129 - Flags: superreview+
Attachment #343129 - Flags: review?(dbaron)
Attachment #343129 - Flags: review+
Pushed 014c18c2bc29
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 343129 [details] [diff] [review]
fix v2

http://hg.mozilla.org/mozilla-central/rev/d153c367c5b5

Was the <nsprpub/configure> change actually wanted ??
No, I backed it out. I wonder why that file is even in the tree at all...
Component: Layout → Reftest
Flags: in-testsuite+
Product: Core → Testing
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.