459619 - Add zoom support to reftest harness

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

My patch supports a reftest-zoom attribute on the root element.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Shouldn't SetupZoom set fullZoom to 1.0 when there's no reftest-zoom attribute?  If not, why not?

Maybe your reftest-sanity test should also compare a div with:
  width: auto; margin: 10px; height: 10px;
to a div with:
  width: auto; margin: 15px; height: 15px;
?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The default is 1.0. We reset the zoom to 1.0 after taking the snapshot, so there shouldn't be any need to set it to 1.0 again for the next test.

Yes, adding that to the reftest-sanity test makes sense.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah... maybe put that assignment to 1.0 in a function called resetZoom() or unsetZoom() just so the symmetry is clear?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 343129 [details] [diff] [review]
fix v2

r+sr=dbaron

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 014c18c2bc29

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 343129 [details] [diff] [review]
fix v2

http://hg.mozilla.org/mozilla-central/rev/d153c367c5b5

Was the <nsprpub/configure> change actually wanted ??

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No, I backed it out. I wonder why that file is even in the tree at all...