Crash [@ nsSVGMarkerFrame::GetCanvasTM]

VERIFIED FIXED

Status

()

Core
SVG
--
critical
VERIFIED FIXED
9 years ago
7 years ago

People

(Reporter: Jesse Ruderman, Assigned: longsonr)

Tracking

(Blocks: 1 bug, 4 keywords)

Trunk
assertion, crash, testcase, verified1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 342956 [details]
testcase (crashes Firefox when loaded)

###!!! ASSERTION: null nsSVGPathGeometry frame: 'mMarkedFrame', file layout/svg/base/src/nsSVGMarkerFrame.cpp, line 112

Crash [@ nsSVGMarkerFrame::GetCanvasTM] (nsSVGMarkerFrame.cpp:114)
I don't see how we can possibly assert that mMarkedFrame is non-null here.  What's making sure it is?
Flags: blocking1.9.1?
(Assignee)

Comment 2

9 years ago
Created attachment 343119 [details] [diff] [review]
patch

The assert is valid, we need to protect ourselves from trying to determine the covered region of something that isn't drawn directly like the contents of a marker.
Assignee: nobody → longsonr
Attachment #343119 - Flags: superreview?(roc)
Attachment #343119 - Flags: review?(roc)
Attachment #343119 - Flags: superreview?(roc)
Attachment #343119 - Flags: superreview+
Attachment #343119 - Flags: review?(roc)
Attachment #343119 - Flags: review+
(Assignee)

Updated

9 years ago
OS: Mac OS X → All
Hardware: PC → All
(Assignee)

Comment 3

9 years ago
checked in 17e8145c4996
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081017 Minefield/3.1b2pre and  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081017 Minefield/3.1b2pre.
Status: RESOLVED → VERIFIED
Flags: blocking1.9.1? → blocking1.9.1+
Keywords: fixed1.9.1
verified fixed on the 1.9.1 branch using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090106 Shiretoko/3.1b3pre and the equivalent Mac build. adding verified keyword.
Keywords: fixed1.9.1 → verified1.9.1
Crash Signature: [@ nsSVGMarkerFrame::GetCanvasTM]
You need to log in before you can comment on or make changes to this bug.