459766 - TM: we don't trace regexp.test

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andreas Gal :gal]

Attachment: patch

Comment 1

[Andreas Gal :gal]

Attachment: patch with mrbkap's input

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 342969 [details] [diff] [review]
patch with mrbkap's input

>diff --git a/js/src/jsregexp.cpp b/js/src/jsregexp.cpp
>+jsint FASTCALL
>+js_Regexp_p_test(JSContext* cx, JSObject* regexp, JSString* str)
>+{
>+    jsval vp[3] = { JSVAL_NULL, OBJECT_TO_JSVAL(regexp), STRING_TO_JSVAL(str) };
>+    if (!regexp_exec_sub(cx, regexp, 1, vp + 2, JS_TRUE, vp))
>+        return -1;

Need to return JSVAL_TO_BOOLEAN(JSVAL_VOID) here.

r=mrbkap with that.

Comment 3

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/3b894cc33338

Comment 4

[Bob Clary [:bc] (inactive)]

test was included in http://hg.mozilla.org/tracemonkey/rev/ad00c6cc4296 bug 459772