Closed Bug 459781 Opened 11 years ago Closed 11 years ago

create our string bundle in a more sane way

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

We create a string bundle in both nsNavBookmarks and in nsNavHistory.  We only need it in nsNavBookmarks if we have to init our defaults (not the common case).  We use it a bit more in history, but we do not need it in the startup path.  We already have a getter for it, that is not used - so let's use it as a lazy getter.  nsNavBookmarks can call it when it actually needs it too, so we don't have to create it twice.
Attached patch v1.0Splinter Review
Attachment #342998 - Flags: review?(dietrich)
Whiteboard: [has patch][needs review dietrich]
Attachment #342998 - Flags: review?(dietrich) → review+
Comment on attachment 342998 [details] [diff] [review]
v1.0

r=me, thanks
Whiteboard: [has patch][needs review dietrich] → [has patch]
Whiteboard: [has patch] → [has patch][has review]
http://hg.mozilla.org/mozilla-central/rev/80890d606324
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in before you can comment on or make changes to this bug.