459782 - check the name calculation rules for nsHTMLLinkAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

These rules were introduced in bug 438325:

The priorities should be:
1. If a link has screen text, use it.
2. If it has an image, use the logic we have (alt and title of the html:img
tag).
3. If the above are not present, and the html:a tag has a title, use that for
an accessible name.

I wonder why the usual rules can't be applied:

1) get name from label
2) get name from subtree
3) get @title

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 350113 [details] [diff] [review]
patch

Looks good. I wonder if the comment:
// Don't use AppendFlatStringFromSubtree for container widgets like menulist

could be moved up closer to the eNameOkFromChildren check in the GetHTMLName implementation?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> (From update of attachment 350113 [details] [diff] [review])
> Looks good. I wonder if the comment:
> // Don't use AppendFlatStringFromSubtree for container widgets like menulist
> 
> could be moved up closer to the eNameOkFromChildren check in the GetHTMLName
> implementation?

eventually we get rid this comment at all becuase we will use role to decide whether we should collect the name from subtree.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350113 [details] [diff] [review]
patch

a191=beltzner

Comment 5

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/ff61501bd888 and http://hg.mozilla.org/mozilla-central/rev/95803938905c

Next time please follow instructions ("make sure you include a commit message and an username in the attachment").