459784 - Error: uncaught exception: 2147500034

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Ronald Killmer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.17) Gecko/20080829 Firefox/2.0.0.17
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081013 Shredder/3.0b1pr

The Error Console began reporting this today 2008/10/13
Error: uncaught exception: 2147500034

This error was not present in the prior days build.

Reproducible: Always

Steps to Reproduce:
1.Start Shredder
2.Open the Error console
3.

Comment 1

[Ronald Killmer]

Forgot to add that this exists in safe mode too.

Comment 2

[Stefan Sitter [:ssitter]]

I can confirm this console error message using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081014 Shredder/3.0b1pre (BuildID: 20081014031016) when starting with a fresh profile.

2147500034 == 0x80004002 == NS_NOINTERFACE according to <http://mxr.mozilla.org/comm-central/source/mozilla/xpcom/base/nsError.h#184>

Comment 3

[Nikolay Shopik]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081014 Shredder/3.0b1pre

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix (and a bit more)

Taking, it looks like some core change (as yet unknown) revealed a long-standing bug in our default command line handler.

We currently have:

397   QueryInterface : function QI(iid) {
398     if (iid.equals(Components.interfaces.nsIModule) &&
399         iid.equals(Components.interfaces.nsISupports))
400       return this;

Note the && which should actually be ||

However, I thought this file could do with some modernising, so I brought in XPCOMUtils which makes it simpler for us to deal with this.

I also dropped the preprocessing of the file because I couldn't see anything that needed preprocessing, and got no differences between source and output, plus I was getting annoyed at having to rebuild each time just to pick up a simple change that I know it could cope with via a symlink.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 343112 [details] [diff] [review]
The fix (and a bit more)

Mmm, pretty.

Comment 7

[Mark Banner (:standard8)]

Checked in, changeset id 621:5233061b8367