Build 2000-07-18-09M17: NT4 Build 2000-07-19-09M17: Linux 6.0 Haven't tried the Mac yet Overview: At the Mail login dialog when the checkbox to "Use Password Manager to remember this value" is selected, the "Blue Box" does not appear. Steps to reproduce: 1. Open Mail 2. Login to a mail account so the login dialog appears. 3. In the login dialog select the checkbox to "Use Password Manager to remember this value" and select OK. Actual Results: No Blue Box appears, in fact nothing seems to happen. Go to Tasks|Privacy and Security|Password Manager|View Stored Password and it does reference the account information so it appears something was saved. Expected Results: The Blue Box should appear so the user knows how to enable Encryption to protect the login information.
lisa, who gets passwd mgr bugs in your group?
- I'll assign it to myself. - Is this needed for beta2?
Build 2000-07-21-08M17: Mac 9.04 Same problem occurs on the mac.
We need Password Manager for beta 2, and we need encryption (using a user supplied key) for the data in the Password Manager to work for beta 2. Therefore, we need this bug fixed, since it does not appear that the user would be able to figure out how to encrypt their Mail passwords with this bug. [cc:ing John Gable]
Fix in hand -- awaiting review from dveditz
Putting on [nsbeta2+] radar for beta2 fix.
Fix checked in. Modified files are wallet.h, wallet.cpp, and singsign.cpp.
Build 2000-07-26-09M17: NT4, Mac 9.04, Linux 6.0 Reopening I enter the password in the login dialog, select the checkbox to use Password Manager to remember the value, select OK and the Blue box never appears.
You probably didn't start with a fresh profile. At a minumum, you need to remove the wallet.caveat entry from your existing prefs.js file. Once the blue-box dialog has been given, it will never be given again during the lifetime of that profile. I'm closing this out assuming that that was your error. If I'm wrong, then reopen again.
Reopening. I deleted the mozregistry.dat file, deleted the Users50 directory, created a new profile and canceled out of Activation. Please see bug# 45987 for detailed steps.
OK, you are describing a different scenerio than the one cited in this report. In particular, the path from the account wizard (which is the scenerio described in bug 45987)comes in to the routine SINGSIGN_StorePassword whereas the path from the single-signon password dialog comes in from SINGSIGN_PromptUsernameAndPassword, SINGSIGN_PromptPassword, and SINGSIGN_Prompt. So to fix the problem you are now reporting I need to add a blue-box call in the SINGSIGN_StorePassword routine.
And now I have a problem. In order for SINGSIGN_StorePassword to put up a modal blue-box dialog, it needs to know the parent window. Take a look at how this is done in SINGSIGN_PromptUsernameAndPassword with the dialog parameter. So I will need to add a dialog parameter to the SINGSIGN_StorePassword routine and the caller of the routine will have to provide this. The caller is in: /mailnews/base/util/nsMsgIncomingServer.cpp, line 674 I can make the changes to single signon to take the added parameter and call the blue-box dialog. But either warren or seth will have to make the change to nsMsgIncomingServer.cpp to obtain a value for the added dialog parameter.
I just added a commented-out call to display the blue-box dialog for the SINGSIGN_StorePassword case. See the code for that routine in extensions/wallet/src/singsign.cpp. The line is: // Wallet_GiveCaveat(nsnull, dialog); ??? what value to use for dialog? When we have a dialog parameter passed in, I'll be able to uncomment this line and the bluebox dialog will appear for the mail-wizard case. Assigning this to seth to make the appropriate change in nsMsgIncomingServer to obtain a value for the dialog parameter.
selmer: Since Seth is out until August who should be assigned to this bug?
reassigning to alecf. Alec, is this something you could take a look at?
I'm not sure what a blue box dialog is, but shouldn't all clients be using the webshell window's nsIPrompt now? That makes single signon work automatically. It also gives us the ability for SINGSIGN_StorePassword to access the dialog object without affecting callers. On a related note, I've realized that nsIPrompt needs a ForgetPassword entry point. That way we can make http use that instead of pulling in the wallet service directly.
The "Blue Box" references a window that should appear which explains the importance of encryption and how to enable it.
morse, need your help here.
I tried to help and did all that I could. Now it's up to the mail team to give me either an nsIPromt* or an nsIDOMWindow*. That's why I assigned it to seth (not realizing that he was on vacation). I'll gladly work with the mail team so that I can make the API change to single-signon at the same time that they change the call to pass in the added argument. Who shall I work with?
That patch looks fine to me. r=morse. Check it in on the branch as well as on the trunk and then we can close out this bug report. Thanks.
Reassigning back to alecf since (1) he already has a fix for it and (2) the fix is in the account wizard.
Can we get this checked into branch ASAP so we have it in Monday builds for QA please?
I see that alecf already checked this in on the trunk and he closed out bug 39345 (the one about removing save-password from account wizard). So I just checked in his patch onto the m17 branch so we can close this one out as well.
thanks steve - I hadn't been online since friday afternoon
Build 2000-07-29-05M17:NT4 Build 2000-07-31-05M17: Mac 9.04, Linux 6.0 Verified Fixed. The Blue Box explaining the importance of encryption and how to enable encryption appears.